Bug 1770775

Summary: libindicator: FTBFS in Fedora rawhide/f31
Product: [Fedora] Fedora Reporter: Kalev Lember <klember>
Component: libindicatorAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 31CC: awilliam, echevemaster, jspaleta, mtasaka, oliver
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libindicator-12.10.1-16.fc32 libindicator-12.10.1-16.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-11 11:27:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kalev Lember 2019-11-11 10:24:53 UTC
libindicator fails to build on F31 and rawhide due to incorrect use of -Werror. -Werror should not be used in distro builds as they can cause build failures whenever something changes in the stack below.

../../libindicator/indicator-object.c: In function 'indicator_object_init':
../../libindicator/indicator-object.c:305:13: error: G_ADD_PRIVATE [-Werror]
  305 |  IndicatorObjectPrivate * priv = G_TYPE_INSTANCE_GET_PRIVATE (self, INDICATOR_OBJECT_TYPE, IndicatorObjectPrivate);
      |             ^~~~~~~~~~~~~~~

https://koji.fedoraproject.org/koji/buildinfo?buildID=1411059

Comment 2 Kalev Lember 2019-11-11 12:59:05 UTC
OK, thanks. I went ahead and merged this to f31 as well as this is where I hit the issue (when building transmission flatpak).

Comment 3 Fedora Update System 2019-11-11 14:17:05 UTC
FEDORA-2019-6507e9484a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-6507e9484a

Comment 4 Fedora Update System 2019-11-13 04:56:27 UTC
libindicator-12.10.1-16.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-6507e9484a

Comment 5 Fedora Update System 2019-11-23 01:30:40 UTC
libindicator-12.10.1-16.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.