Bug 1770784
| Summary: | Review Request: perl-Devel-Callsite - Get caller return OP address and Perl interpreter context | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yanko Kaneti <yaneti> |
| Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jplesnik, package-review |
| Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-11-11 16:30:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Yanko Kaneti
2019-11-11 10:52:36 UTC
Source file is ok
Summary is ok
License
FIX: The license is 'GPLv2+ or Artistic'
Check the section 'LICENSE AND COPYRIGHT' in the Callsite.pm
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires:
FIX: Please add following buil-requires:
- perl(B) - t/01callsite.t:4
- perl(warnings) - t/01callsite.t:2
$ rpm -qp --requires perl-Devel-Callsite-1.0.1-1.fc32.x86_64.rpm | sort | uniq -c | grep -v rpmlib
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 libperl.so.5.30()(64bit)
1 libpthread.so.0()(64bit)
1 libpthread.so.0(GLIBC_2.2.5)(64bit)
1 perl(base)
1 perl(Exporter)
1 perl(:MODULE_COMPAT_5.30.1)
1 perl(vars)
1 perl(:VERSION) >= 5.5.0
1 perl(XSLoader)
1 rtld(GNU_HASH)
Binary requires are Ok.
$ rpm -qp --provides perl-Devel-Callsite-1.0.1-1.fc32.x86_64.rpm | sort | uniq -c
1 perl(Devel::Callsite) = 1.0.1
1 perl-Devel-Callsite = 1.0.1-1.fc32
1 perl-Devel-Callsite(x86-64) = 1.0.1-1.fc32
Binary provides are Ok.
$ rpmlint perl-Devel-Callsite*
perl-Devel-Callsite.x86_64: W: hidden-file-or-dir /usr/lib64/perl5/vendor_perl/auto/Devel/Callsite/.packlist
perl-Devel-Callsite.x86_64: W: perl-temp-file /usr/lib64/perl5/vendor_perl/auto/Devel/Callsite/.packlist
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
FIX: Please remove packlist. The easier way to remove .packlist is used
NO_PACKLIST option, which is part of perl(ExtUtils::MakeMaker) >= 6.76.
perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" NO_PACKLIST=1
TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.
TODO: In spec file, please consider replacing
1)
perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
make %{?_smp_mflags}
by
perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" NO_PACKLIST=1 NO_PERLLOCAL=1
%make_build
2)
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
by
%make_install
These changes work on all currently supported Fedora and EPEL targets.
Please correct all 'FIX' issues and consider fixing 'TODO' items and
provide new spec file.
Resolution:
Not approved
-2 - Additional fixes as per review Spec URL: http://declera.com/~yaneti/perl-Devel-Callsite/perl-Devel-Callsite.spec SRPM URL: http://declera.com/~yaneti/perl-Devel-Callsite/perl-Devel-Callsite-1.0.1-2.fc32.src.rpm TODO: If you add option 'NO_PERLLOCAL=1' to 'perl Makefile.PL ...'
then you can remove
rm -f $RPM_BUILD_ROOT/%{_libdir}/perl5/perllocal.pod
> License
> FIX: The license is 'GPLv2+ or Artistic'
> Check the section 'LICENSE AND COPYRIGHT' in the Callsite.pm
Ok
> BuildRequires:
> FIX: Please add following buil-requires:
> - perl(B) - t/01callsite.t:4
> - perl(warnings) - t/01callsite.t:2
Ok
> FIX: Please remove packlist. The easier way to remove .packlist is used
> NO_PACKLIST option, which is part of perl(ExtUtils::MakeMaker) >= 6.76.
> perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
> NO_PACKLIST=1
Ok
> TODO: In spec file, please consider replacing
> 1)
> perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
> make %{?_smp_mflags}
> by
> perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
> NO_PACKLIST=1 NO_PERLLOCAL=1
> %make_build
Ok
> 2)
> make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
> by
> %make_install
Ok
Please consider fixing 'TODO' item.
Resolution:
Approved
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Devel-Callsite Imported. Fixed the last TODO. Built in rawhide. Thanks for the review. |