Bug 1770949
| Summary: | Review Request: nodejs-handle-thing - Wrap Streams2 instance into a HandleWrap | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jared Smith <jsmith.fedora> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-01-07 00:45:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449, 956806, 1736292 | ||
|
Description
Jared Smith
2019-11-11 14:45:26 UTC
- Tests don't work:
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.6PxhSJ
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
+ /usr/bin/mocha -R spec
Handle Thing
normal
(node:28294) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
1) should write data to Socket
β should read data from Socket
2) should invoke `close` callback
β should kill pending requests (77ms)
β should invoke `getPeerName` callback
3) should emit ECONNRESET at `close` event
lazy
4) should write data to Socket
β should read data from Socket (52ms)
5) should invoke `close` callback
β should kill pending requests (125ms)
5 passing (10s)
5 failing
1) Handle Thing normal should write data to Socket:
Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.
at listOnTimeout (internal/timers.js:531:17)
at processTimers (internal/timers.js:475:7)
2) Handle Thing normal should invoke `close` callback:
Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.
at listOnTimeout (internal/timers.js:531:17)
at processTimers (internal/timers.js:475:7)
3) Handle Thing normal should emit ECONNRESET at `close` event:
Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.
at listOnTimeout (internal/timers.js:531:17)
at processTimers (internal/timers.js:475:7)
4) Handle Thing lazy should write data to Socket:
Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.
at listOnTimeout (internal/timers.js:531:17)
at processTimers (internal/timers.js:475:7)
5) Handle Thing lazy should invoke `close` callback:
Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.
at listOnTimeout (internal/timers.js:531:17)
at processTimers (internal/timers.js:475:7)
error: Bad exit status from /var/tmp/rpm-tmp.6PxhSJ (%check)
Bad exit status from /var/tmp/rpm-tmp.6PxhSJ (%check)
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |