Bug 177107
| Summary: | Review Request: libgeda - library for gEDA circuit design software | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Wojciech Kazubski <wk> |
| Component: | Package Review | Assignee: | Greg DeKoenigsberg <gdk> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hdegoede |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-06-16 17:29:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 177106 | ||
| Bug Blocks: | 177108, 177110, 177113, 177115, 177413 | ||
|
Description
Wojciech Kazubski
2006-01-06 12:55:44 UTC
There is new release of libgeda available. Specfile: http://www.sp5pbe.waw.pl/~sp5smk/fedora-extras/specs2/libgeda.spec Source RPM: http://www.sp5pbe.waw.pl/~sp5smk/libgeda-20060123-1.fc4.src.rpm Some remarks on your spec file (without having built it): 1. Missing requirements: Requires(post): /sbin/ldconfig Requires(post): /sbin/install-info Requires(preun): /sbin/install-info 2. IIRC, due to an issue in rpm, the %post, %preun etc. sections must be separated by blank lines, otherwise rpm will concatenate then into one section. 3. The same remarks as on you libgdeda specs also apply here (pkgconfig, includedir, static libs). 1. Finished library has autogenerated dependence on ldconfig. Does it need extra dependency for install/uninstal? Dependency on install-info is not autogenerated so it may be good to include it explicitely. I will look into other packages having info files. 2. Some half of existing packages have those sections without empty line between them. I have not seen any problem so far. (In reply to comment #3) > 1. Finished library has autogenerated dependence on ldconfig. Does it need > extra dependency for install/uninstal? Yes. You are using scriptlets consisting of multiple lines. For these, explicit Requires(...) on all tools being used inside are necessary. > 2. Some half of existing packages have those sections without empty line > between them. I have not seen any problem so far. Check the output of "rpm -q --scripts" on your package. There have been cases where rpm "lumped together" such scripts into one script. This had caused sporatic installation/deinstallation errors. I have applied some corrections to gEDA specfiles in response to the above comments. Specfiles are at: http://www.sp5pbe.waw.pl/~sp5smk/fedora-extras/specs2/ Source RPM is at: http://www.sp5pbe.waw.pl/~sp5smk/fedora-extras/srpms/ Please check/review Closing as won't fix because of non repsonsiveness of the submitter see bug 177106 |