Bug 1771338

Adding FE-NEEDSPONSOR, as the submitter is not currently a packager

Submission is in incorrect format, should not be zipped into a single file, SPEC url and SRPM URL should point to those files specifically, so that fedora-review works with the BZ

package fails to build:
[exec] main:
     [exec]     [mkdir] Created dir: /home/nhorman/rpmbuild/BUILD/contrib/features/hex2bin/target/dist
     [exec]     [mkdir] Created dir: /home/nhorman/rpmbuild/BUILD/contrib/features/hex2bin/target/dist-deps
     [exec]     [touch] Creating /home/nhorman/rpmbuild/BUILD/contrib/features/hex2bin/target/dist/builder/x
     [exec]      [exec] PREFIX=/opt/mtwilson/share/hex2bin
     [exec]      [exec] mkdir: cannot create directory '/opt/mtwilson': Permission denied
     [exec]      [exec] gcc -fstack-protector-strong -fPIE -fPIC -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -o hex2bin hex2bin.c -z noexecstack -z relro -z now -pie
     [exec]      [exec] mkdir: cannot create directory '/opt/mtwilson': Permission denied
     [exec]      [exec] chmod +x hex2bin
     [exec]      [exec] mkdir: cannot create directory '/opt/mtwilson': Permission denied
     [exec]      [exec] mkdir -p /opt/mtwilson/share/hex2bin/bin
     [exec]      [exec] make: *** [Makefile:13: install] Error 1
     [exec]      [exec] Failed to make install hex2bin
     [exec]      [exec] mkdir: cannot create directory '/opt/mtwilson': Permission denied
     [exec]      [exec] make: *** [Makefile:13: install] Error 1
     [exec] [INFO] ------------------------------------------------------------------------
     [exec] [INFO] Reactor Summary:
     [exec] [INFO] 
     [exec] [INFO] hex2bin-dist 1.0 ................................... FAILURE [  1.931 s]
     [exec] [INFO] mtwilson-maven-build-contrib-features 1.1 .......... SKIPPED
     [exec] [INFO] ------------------------------------------------------------------------
     [exec] [INFO] BUILD FAILURE
     [exec] [INFO] ------------------------------------------------------------------------
     [exec] [INFO] Total time: 2.053 s
     [exec] [INFO] Finished at: 2019-11-18T13:49:48-05:00
     [exec] [INFO] ------------------------------------------------------------------------
     [exec] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.7:run (default-cli) on project hex2bin-dist: An Ant BuildException has occured: exec returned: 2
     [exec] [ERROR] around Ant part ...<exec failonerror="true" dir="/home/nhorman/rpmbuild/BUILD/contrib/features/hex2bin/target" executable="/bin/bash">... @ 27:122 in /home/nhorman/rpmbuild/BUILD/contrib/features/hex2bin/target/antrun/build-main.xml
     [exec] [ERROR] -> [Help 1]
     [exec] [ERROR] 
     [exec] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
     [exec] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
     [exec] [ERROR] 
     [exec] [ERROR] For more information about the errors and possible solutions, please read the following articles:
     [exec] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
     [exec] Result: 1

A summary of this bug report is invalid. Review requests must have this format:

  Review Request: PACKAGE_NAME - PACKAGE_SUMMARY

The review request must link to _directly_ downloadable SPEC and SRPM files. Hiding them into a ZIP archive is not the right way.

We have re-uploaded the source RPM and spec files to a new location:

Spec URL: https://github.com/intel-secl/verification-service/blob/v1.5.1/packages/host-verification-service-linux/src/build/host-verification-service.spec
SRPM URL: https://github.com/intel-secl/verification-service/blob/v1.5.1/packages/host-verification-service-linux/src/build/host-verification-service-4.5-1.el7.src.rpm

We are currently still working through the Koji build failures and will update once we have a resolution.

I'll also update the title to meet the format requirement.

Hi Guys,

As i am new to this can you please tell how you are trying to review this package. 
I am using fedora rawhide server (VERSION_ID=32)

1. For me it is saying package is not in correct format.

I manually downloaded the srpm file , then tried to run it, but getting below errors

Step1: wget https://github.com/intel-secl/verification-service/blob/v1.5.1/packages/host-verification-service-linux/src/build/host-verification-service-4.5-1.el7.src.rpm

[root@localhost ~]# rpm -qpl host-verification-service-4.5-1.el7.src.rpm
error: host-verification-service-4.5-1.el7.src.rpm: not an rpm package (or package manifest)

[root@localhost ~]# fedora-review --rpm-spec -n host-verification-service-4.5-1.el7.src.rpm
INFO: Processing local files: host-verification-service-4.5-1.el7.src.rpm
INFO: Getting .spec and .srpm Urls from : Local files in /root
INFO:   --> SRPM url: file:///root/host-verification-service-4.5-1.el7.src.rpm
INFO: Using review directory: /root/host-verification-service
argument is not an RPM package
cpio: premature end of archive
WARNING: Cannot unpack /root/host-verification-service/srpm/host-verification-service-4.5-1.el7.src.rpm into /root/host-verification-service/srpm-unpacked
argument is not an RPM package
cpio: premature end of archive
WARNING: Cannot unpack /root/host-verification-service/srpm/host-verification-service-4.5-1.el7.src.rpm into /root/host-verification-service/srpm-unpacked
ERROR: 'Cannot find spec file in srpm' (logs in /root/.cache/fedora-review.log)

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.