Bug 1771769

Thomas: I don't think you can set "fedora-review+" yourself.

Also this package can not be approved as-is. You are packaging pre-built binaries. Please use the github source release and do all the building in your spec file. Please consult the packaging guide lines [1], your sponsor or fedora-devel if you need help.

[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/

Please take: https://bugzilla.redhat.com/show_bug.cgi?id=1771173

Rename selenium-geckodriver to simply geckodriver like the upstream.

Get the source package like
Source0: %{url}/archive/%{version}/geckodriver-%{version}.tar.gz

where URL: https://github.com/mozilla/geckodriver/releases

Use %autosetup which is the equivalent of %setup -q

Luya: The most important thing is that the current spec just ships a pre-built binary. The package as-is MUST NOT be approved! I think Thomas should focus on that first.

Also it might be non-trivial to package geckodriver which requires a few rust packages. But anyway: Build from source first before tackling  cosmetic issues.

(In reply to Felix Schwarz from comment #4)
> Luya: The most important thing is that the current spec just ships a
> pre-built binary. The package as-is MUST NOT be approved! I think Thomas
> should focus on that first.

Comment #3 listed the source. 
As geckodriver is written a rust, a guideline to write the spec file exists on 
https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/

First step is to use rust2rpm script as a start like "rust2rpm geckodriver" which will ease the process.

Thanks for all information, let me few days to propose a new package

Hello

For information, I never did a rust package :)

Here is a new version for geckodriver :
SPEC : https://fedorapeople.org/~totol/geckodriver.spec
SRPM : https://fedorapeople.org/~totol/rust-geckodriver-0.26.0-1.fc32.src.rpm
Koji Build : https://koji.fedoraproject.org/koji/taskinfo?taskID=39266809

To do this, I had to integrate into Geckodriver sources the next dependencies :
cookie-rs
mozdevice
mozprofile
mozrunner
mozversion
podio
rust-plist
serde-repr
webdriver
winapi-rs
winreg-rs
zip-rs

Some of these dependencies are not on crates.io

What is the best strategy ? Do I have to package each dependencies to fedora ?

Thanks

Created attachment 1639145 [details]
geckodriver.spec generated from rust2rpm geckodriver 0.8.0

Hello Thomas, 

It is also my first time packaging rust. Once following the step, the process is easy.

Here is a starter for the attached spec file generated with the following command:

rust2rpm geckodriver 0.8.0

 It turned out the last available source at crates.io was 0.8.0 before it was yanked. 

You can change the following lines 
URL:           https://github.com/mozilla/geckodriver
Source0:       %{url}/archive/%{crate}-%{version}.tar.gz

Legends
-------
%{crate} is from %global crate geckodriver
%{url} is the defined URL variable
%{version} is the defined Version i.e. 0.26.0


And yes, if there are missing dependency from the Fedora repository, you will need to package them.

Any update for the change?

Hello

I'm missing time to move forward on this but I will.

Regards

Thomas

Thanks for the update.

Finally, too many rust package to package. I stop

Regards

Closing this report based on comment #12. Feel free to reopen should you decide to resubmit this package for review.