Bug 1772029

Summary: Show error on invalid oidc issuer
Product: Red Hat Satellite Reporter: Nikhil Kathole <nkathole>
Component: AuthenticationAssignee: Rahul Bajaj <rabajaj>
Status: CLOSED ERRATA QA Contact: Nikhil Kathole <nkathole>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.7.0CC: egolov, mhulan
Target Milestone: 6.7.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: foreman-1.24.0-0.14.RC3 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-14 13:27:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Nikhil Kathole 2019-11-13 13:38:01 UTC
Description of problem:

If a valid issuer is not provided in the satellite settings, then there is no way a user can understand why SSO failed.

The method `valid_issuer?` in openid_connect.rb checks if a valid issuer is present or not. But if that fails authentication
flow ends with a error saying `SSO failed` but does not specify why.

Version-Release number of selected component (if applicable):
Satellite 6.7.0 snap 1

How reproducible:

Steps to Reproduce:
1) Provide a wrong issuer in the Satellite settings.
2) Try to login via SSO.

Actual results:

Expected results:

Additional info:

Comment 3 Bryan Kearney 2019-11-13 15:04:57 UTC
Upstream bug assigned to rabajaj

Comment 4 Rahul Bajaj 2019-11-20 17:38:57 UTC

Please find the working PR here: https://projects.theforeman.org/issues/28086


Comment 5 Bryan Kearney 2019-11-24 13:05:20 UTC
Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/28086 has been resolved.

Comment 6 Tomer Brisker 2019-11-25 08:49:18 UTC
Connecting redmine issue https://projects.theforeman.org/issues/28086 from this bug

Comment 10 errata-xmlrpc 2020-04-14 13:27:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.