Bug 1772373

Summary:	perl-DBD-Pg tests failing due to rebase of libpq 12 and PostgreSQL server 12
Product:	Red Hat Enterprise Linux 8	Reporter:	Petr Pisar <ppisar>
Component:	perl-DBD-Pg	Assignee:	perl-maint-list
Status:	CLOSED CURRENTRELEASE	QA Contact:	RHEL CS Apps Subsystem QE <rhel-cs-apps-subsystem-qe>
Severity:	low	Docs Contact:
Priority:	low
Version:	8.2	CC:	bnater, hhorak, jorton, lmiksik, perl-maint-list, ppisar, rhel-stacks-subsystem-qe
Target Milestone:	rc	Keywords:	Patch, Reproducer, Triaged
Target Release:	8.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	perl-DBD-Pg-3.7.4-3.el8_1	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	1770235	Environment:
Last Closed:	2020-11-06 07:54:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1754713

Description Petr Pisar 2019-11-14 09:33:19 UTC

+++ This bug was initially created as a clone of Bug #1770235 +++

This bug was initially created as a copy of Bug #1768846

Description of problem:

* Tests /CoreOS/perl-DBD-Pg/Sanity/upstream-tests fail with the rebased libpq done for rhel-8.1.1.

* After talking to ppisar, it looks like the tests were fixed upstream (see https://bugzilla.redhat.com/show_bug.cgi?id=1768846#c5) and it looks like a good idea to fix this together with delivering postgresql:12 stream (tracked in bz#1721822) + libpq rebase in rhel-8.1.1 (tracked in bz#1749461)

* We still would like to keep bz#1768846 opened for libpq, because it still looks important enough for more investigation, but we're so far convinced the changes in that library do not change ABI, most probably just a slight change in behavior that perl-DBD-pg depended on changed, which should be not relevant nor visible for users.

How reproducible:
Always

Steps to Reproduce:
1. run tests for perl-DBD-Pg with the libpq-12.0 (/CoreOS/perl-DBD-Pg/Sanity/upstream-tests)

Actual results:
4 tests in 03dbmethod.t fails


Expected results:
No fail


Additional info:
see https://bugzilla.redhat.com/show_bug.cgi?id=1768846#c5

--- Additional comment from Honza Horak on 2019-11-08 14:45:09 GMT ---

Setting qa_test_coverage+ because the tests already exist.

[...]

--- Additional comment from Petr Pisar on 2019-11-11 09:32:40 GMT ---

We have perl-DBD-Pg twice in RHEL-8. Once as a non-modular package in BaseOS and once as a modular package of perl-DBD-Pg:3.7 stream in AppStream. We need to fix both of them.

[...]
--- Additional comment from Petr Pisar on 2019-11-14 09:24:19 GMT ---

There is also a request to pass perl-DBD-Pg tests against PostreSQL 12 server. As the server removes some features and a perl-DBD-Pg library uses them and the tests checks for them, it necessary to apply additional seven patches. These patches preserve perl-DBD-Pg API and all tests pass against PostregreSQL server 9.6, 10, and 12. I will include them referring to this bug report.

-------

RHEL-8.2.0 is affected.