Bug 1772762

Summary: [RFE] Size of disks added is not shown when VM_Reconfigure
Product: Red Hat CloudForms Management Engine Reporter: Khushbu Borole <kborole>
Component: AutomateAssignee: William Fitzgerald <wfitzger>
Status: CLOSED ERRATA QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.6CC: bmidwood, dmetzger, fdewaley, gmccullo, hkataria, lavenel, mkanoor, mpovolny, mshriver, nansari, nitescu.adrian, obarenbo, simaishi, tfitzger, wfitzger
Target Milestone: GAKeywords: FutureFeature, RFE, ZStream
Target Release: 5.11.8Flags: simaishi: cfme-5.11.z+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.8.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-09-30 14:01:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Feature
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Services -> Requests -> Description none

Description Khushbu Borole 2019-11-15 06:06:32 UTC
Created attachment 1636355 [details]
Services -> Requests -> Description

Description of problem:
The `Reconfigure VM` feature shows the Memory, CPU and Disk details answering the 'How Much ?' question.
How much
Memory -> 1024MB
Sockets -> 2
Cores -> 1
Disk -> 1

Hence it answers `How Much disks ?` as 1 and not look for how much disk space

Version-Release number of selected component (if applicable):
Red Hat CloudForms 4.7

How reproducible:
Always

Steps to Reproduce:
1. Create VM
2. Reconfigure VM -> Add Disk

Actual results:
Services -> Requests does not show the size of disk

Expected results:
It's very important to see how much disk space the requester asked for.

Comment 5 CFME Bot 2020-01-14 13:50:33 UTC
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/df00552f31d99c1387b493c94128a6e55b5dc057
commit df00552f31d99c1387b493c94128a6e55b5dc057
Author:     William Fitzgerald <wfitzger>
AuthorDate: Fri Jan  3 10:42:13 2020 -0500
Commit:     William Fitzgerald <wfitzger>
CommitDate: Fri Jan  3 10:42:13 2020 -0500

    Updated description for vm_reconfigure_task in app/models to add disk size information.

    Previously we were just showing number of disks added, now we will display disk size(s) in the description.

    Fixes:https://bugzilla.redhat.com/show_bug.cgi?id=1772762
    Removed spaces to fix bot warning
    Adding tests for single and multiple disk adds
    Removed spaces to fix bot warning again
    Removed 2 blank lines and made 1 long line into 2 lines as requested

 app/models/vm_reconfigure_task.rb | 2 +-
 spec/models/vm_reconfigure_task_spec.rb | 66 +
 2 files changed, 67 insertions(+), 1 deletion(-)

Comment 6 Khushbu Borole 2020-01-29 06:01:39 UTC
Hello,

I can see engineers working on this.

I just wanted to add that , it's the same thing even when reconfiguring existing disks.

It says :
  Disk Add: 1
  Resize Disk : 1

The Disk size is not mentioned in any of the cases.

Thank you.

Comment 9 CFME Bot 2020-08-20 14:50:28 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/dc53bbfd72dcf70c682fdfcfaec30a9ad7052019
commit dc53bbfd72dcf70c682fdfcfaec30a9ad7052019
Author:     Greg McCullough <gmccullo>
AuthorDate: Tue Jan 14 13:49:32 2020 +0000
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu Aug 20 13:12:27 2020 +0000

    Merge pull request #19681 from billfitzgerald0120/vm_reconfig_add_disk_info_to_description

    Updated vm_reconfigure_task in app/models to add disk size information.

    (cherry picked from commit d8a100508b7ac50732d5844dc07ae717d62fc03a)

    https://bugzilla.redhat.com/show_bug.cgi?id=1772762

 app/models/vm_reconfigure_task.rb | 2 +-
 spec/models/vm_reconfigure_task_spec.rb | 66 +
 2 files changed, 67 insertions(+), 1 deletion(-)

Comment 17 errata-xmlrpc 2020-09-30 14:01:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: CloudForms 5.0.8 security, bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4134