Bug 1772767

Summary: [sriov] cluster:network_attachment_definition_instances:max{networks="sriov"} should not '-1' When the sriov type pod is deleted
Product: OpenShift Container Platform Reporter: zhaozhanqi <zzhao>
Component: NetworkingAssignee: Aneesh Puttur <aputtur>
Networking sub component: SR-IOV QA Contact: zhaozhanqi <zzhao>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: high CC: aputtur, bbennett, zshi
Version: 4.3.0   
Target Milestone: ---   
Target Release: 4.3.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-23 11:12:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description zhaozhanqi 2019-11-15 06:18:51 UTC
Description of problem:
Create pod with sriov type, when the pod is deleted. found the 
cluster:network_attachment_definition_instances:max{networks="sriov"} is '-1'

Version-Release number of selected component (if applicable):
4.3.0-0.nightly-2019-11-13-233341

How reproducible:
always

Steps to Reproduce:
1. Create pod with sriov type
2. Check the value of 'cluster:network_attachment_definition_instances:max{networks="sriov"}'
3. Delete the pod
4. Found the 'cluster:network_attachment_definition_instances:max{networks="sriov"}' is -1

Actual results:


Expected results:


Additional info:

Comment 1 zenghui.shi 2019-12-06 10:26:41 UTC
It looks like -1 count also appear with macvlan pod commented here: https://bugzilla.redhat.com/show_bug.cgi?id=1770387#c3

@Aneesh, do you think the fix in BZ1770387 can also fix this issue?

Comment 2 Aneesh Puttur 2019-12-06 14:53:01 UTC
Yes, fix in BZ1770387 can also fix this issue
Fixed with the following the merge
https://github.com/openshift/multus-admission-controller/pull/20
https://github.com/openshift/multus-admission-controller/pull/19

Comment 4 Aneesh Puttur 2019-12-10 02:53:32 UTC
Changes are merged.

Comment 5 zhaozhanqi 2019-12-11 07:25:28 UTC
Verfied this bug on 4.3.0-0.nightly-2019-12-09-234911

Comment 7 errata-xmlrpc 2020-01-23 11:12:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0062