Bug 1772805

Summary: perl-DBD-Pg tests failing due to rebase of libpq 12 and PostgreSQL server 12
Product: Red Hat Enterprise Linux 8 Reporter: Petr Pisar <ppisar>
Component: perl-DBD-Pg-3.7-moduleAssignee: perl-maint-list
Status: CLOSED ERRATA QA Contact: RHEL CS Apps Subsystem QE <rhel-cs-apps-subsystem-qe>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.1CC: bnater, hhorak, jorton, kanderso, mkyral, perl-maint-list, ppisar, rhel-stacks-subsystem-qe
Target Milestone: rcKeywords: Patch, Reproducer, Triaged
Target Release: 8.0Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: perl-DBD-Pg-3.7-8010120191115065723.18319d51 perl-DBD-Pg-3.7-8010120191115065723.c5869bed Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: 1770235
: 1773658 (view as bug list) Environment:
Last Closed: 2020-02-04 12:26:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1749461, 1768846    

Description Petr Pisar 2019-11-15 08:39:09 UTC 
+++ This bug was initially created as a clone of Bug #1770235 +++

This bug was initially created as a copy of Bug #1768846

Description of problem:

* Tests /CoreOS/perl-DBD-Pg/Sanity/upstream-tests fail with the rebased libpq done for rhel-8.1.1.

* After talking to ppisar, it looks like the tests were fixed upstream (see https://bugzilla.redhat.com/show_bug.cgi?id=1768846#c5) and it looks like a good idea to fix this together with delivering postgresql:12 stream (tracked in bz#1721822) + libpq rebase in rhel-8.1.1 (tracked in bz#1749461)

* We still would like to keep bz#1768846 opened for libpq, because it still looks important enough for more investigation, but we're so far convinced the changes in that library do not change ABI, most probably just a slight change in behavior that perl-DBD-pg depended on changed, which should be not relevant nor visible for users.

How reproducible:
Always

Steps to Reproduce:
1. run tests for perl-DBD-Pg with the libpq-12.0 (/CoreOS/perl-DBD-Pg/Sanity/upstream-tests)

Actual results:
4 tests in 03dbmethod.t fails


Expected results:
No fail


Additional info:
see https://bugzilla.redhat.com/show_bug.cgi?id=1768846#c5

--- Additional comment from Honza Horak on 2019-11-08 14:45:09 GMT ---

Setting qa_test_coverage+ because the tests already exist.

[...]

--- Additional comment from Petr Pisar on 2019-11-11 09:32:40 GMT ---

We have perl-DBD-Pg twice in RHEL-8. Once as a non-modular package in BaseOS and once as a modular package of perl-DBD-Pg:3.7 stream in AppStream. We need to fix both of them.

[...]

--- Additional comment from Petr Pisar on 2019-11-14 09:24:19 GMT ---

There is also a request to pass perl-DBD-Pg tests against PostreSQL 12 server. As the server removes some features and a perl-DBD-Pg library uses them and the tests checks for them, it necessary to apply additional seven patches. These patches preserve perl-DBD-Pg API and all tests pass against PostregreSQL server 9.6, 10, and 12. I will include them referring to this bug report.

-----

perl-DBD-Pg:3.7 module is affected.
Comment 8 errata-xmlrpc 2020-02-04 12:26:27 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0347