Bug 1773639

Summary: rpmlint and rpmgrill errors on kata-runtime build
Product: [Fedora] Fedora Reporter: Christophe de Dinechin <dinechin>
Component: kata-runtimeAssignee: Christophe de Dinechin <dinechin>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 32CC: dinechin, fidencio
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-19 09:33:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 1 Christophe de Dinechin 2019-11-19 12:47:47 UTC
rpmlint output:

rpmlint FAILED for kata-runtime-1.9.0-1.fc31 (x86_64, noarch, src): 1 errors, 4 warnings

##### SRPMs #####
kata-runtime.src:78: W: rpm-buildroot-usage %prep DESTDIR=%{buildroot} \\\
kata-runtime.src: E: specfile-error warning: -u use in %forgemeta is deprecated, use -z instead to select a separate set of rpm variables!
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

##### RPMs  #####
kata-runtime.x86_64: W: no-manual-page-for-binary containerd-shim-kata-v2
kata-runtime.x86_64: W: no-manual-page-for-binary kata-collect-data.sh
kata-runtime.x86_64: W: no-manual-page-for-binary kata-runtime
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

RPMs tested:
kata-runtime-1.9.0-1.fc31.src.rpm
kata-runtime-1.9.0-1.fc31.x86_64.rpm

If you want to whitelist some warnings/errors, see https://fedoraproject.org/wiki/Taskotron/Tasks/dist.rpmlint#whitelist

Comment 2 Christophe de Dinechin 2019-11-19 12:48:26 UTC
Relevant portion of rpmgrill output:

     {
         "module" : "ElfChecks",
         "order" : 14,
         "results" : [
            {
               "arch" : "x86_64",
               "code" : "PiePartialRelro",
               "context" : {
                  "excerpt" : [
                     "/usr/bin/kata-runtime",
                     "/usr/libexec/kata-containers/kata-netmon"
                  ]
               },
               "diag" : "Files <is|are> PIE but only partially RELRO:",
               "subpackage" : "kata-runtime"
            }
         ],
         "run_time" : 0,
         "status" : "completed"
      },

Comment 3 Christophe de Dinechin 2019-12-03 15:48:40 UTC
> kata-runtime.src:78: W: rpm-buildroot-usage %prep DESTDIR=%{buildroot} \\\

Fixed in https://src.fedoraproject.org/rpms/kata-runtime/c/70e8140d415f194c74a8317fd178492123b0941e?branch=master

Fix verified in https://taskotron.fedoraproject.org/artifacts/all/6e3b06ec-12f6-11ea-9b78-525400364adf/tests.yml/kata-runtime-1.9.1-1.fc32.log:

rpmlint FAILED for kata-runtime-1.9.1-1.fc32 (x86_64, noarch, src): 1 errors, 3 warnings

##### SRPMs #####
kata-runtime.src: E: specfile-error warning: -u use in %forgemeta is deprecated, use -z instead to select a separate set of rpm variables!
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

##### RPMs  #####
kata-runtime.x86_64: W: no-manual-page-for-binary containerd-shim-kata-v2
kata-runtime.x86_64: W: no-manual-page-for-binary kata-collect-data.sh
kata-runtime.x86_64: W: no-manual-page-for-binary kata-runtime
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

RPMs tested:
kata-runtime-1.9.1-1.fc32.src.rpm
kata-runtime-1.9.1-1.fc32.x86_64.rpm

If you want to whitelist some warnings/errors, see https://fedoraproject.org/wiki/Taskotron/Tasks/dist.rpmlint#whitelist

Comment 4 Ben Cotton 2020-02-11 17:42:27 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 5 Fabiano FidĂȘncio 2021-04-19 06:42:51 UTC
Christophe,

What's the status of this issue?  Is this stale?
Please, take some time and consider whether this should still be opened, testing against kata-containers package, as packages for 1.x will won't be updated after May 12th (as the 1.x project upstream will reach its EOL: http://lists.katacontainers.io/pipermail/kata-dev/2021-April/001843.html)

Best Regards

Comment 6 Christophe de Dinechin 2021-04-19 09:33:23 UTC
I believe that it is stale:

- For kata-containers:
% rpmlint kata-containers.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

- For kata-runtime:
% rpmlint kata-runtime.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

Closing.