Bug 1773884

Summary:	Review Request: perl-Object-HashBase - Build hash-based classes
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Object-HashBase-0.008-1.fc32	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-21 08:13:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2019-11-19 08:56:01 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Object-HashBase/perl-Object-HashBase.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Object-HashBase/perl-Object-HashBase-0.008-1.fc32.src.rpm
Description:
This package is used to generate classes based on hash references. Using this
class will give you a new() method, as well as generating accessors you
request.  Generated accessors will be getters, set_ACCESSOR setters will also
be generated for you. You also get constants for each accessor (all caps)
which return the key into the hash for that accessor. Single inheritance is
also supported.

Fedora Account System Username: pppisar

Comment 1 Jitka Plesnikova 2019-11-19 10:04:23 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Object-HashBase-0.008-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(strict)
      1 perl(warnings)
$ rpm -qp --requires perl-Object-HashBase-tools-0.008-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(Object::HashBase)
      1 perl-Object-HashBase = 0.008-1.fc32
      1 perl(Object::HashBase::Inline)
      1 perl(Object::HashBase::Test)
      1 perl(strict)
      1 perl(Test::More) >= 0.98
      1 perl(vars)
      1 perl(warnings)
      1 /usr/bin/perl 
Binary requires are Ok.

$ rpm -qp --provides perl-Object-HashBase-0.008-1.fc32.noarch.rpm | sort | uniq -c
      1 perl(Object::HashBase) = 0.008
      1 perl-Object-HashBase = 0.008-1.fc32
$ rpm -qp --provides perl-Object-HashBase-tools-0.008-1.fc32.noarch.rpm | sort | uniq -c
      1 perl(Object::HashBase::Inline) = 0.008
      1 perl(Object::HashBase::Test) = 0.008
      1 perl-Object-HashBase-tools = 0.008-1.fc32
Binary provides are Ok.

$ rpmlint ./perl-Object-HashBase*
perl-Object-HashBase.noarch: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-Object-HashBase.noarch: W: spelling-error %description -l en_US getters -> fetters, setters, netters
perl-Object-HashBase.noarch: W: spelling-error %description -l en_US accessor -> accessory, access or, access-or
perl-Object-HashBase.src: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-Object-HashBase.src: W: spelling-error %description -l en_US getters -> fetters, setters, netters
perl-Object-HashBase.src: W: spelling-error %description -l en_US accessor -> accessory, access or, access-or
perl-Object-HashBase-tools.noarch: W: spelling-error Summary(en_US) inlined -> unlined, inline, inclined
perl-Object-HashBase-tools.noarch: W: no-manual-page-for-binary hashbase_inc.pl
3 packages and 1 specfiles checked; 0 errors, 8 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 2 Gwyn Ciesla 2019-11-19 14:49:22 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Object-HashBase

Comment 3 Petr Pisar 2019-11-19 15:54:46 UTC

Thank you for the review and the repository.

Comment 4 Petr Pisar 2019-11-19 16:00:59 UTC

The Koji build task fails with "BuildError: package perl-Object-HashBase not in list for tag f32-updates-candidate" even after an hour. It seems Koji white list was not properly updated. <https://pagure.io/releng/issue/9035>.

Comment 5 Petr Pisar 2019-11-21 08:13:18 UTC

Fixed by relengs.