Bug 1773910

Summary:	Space for platform/region selecting does not work
Product:	OpenShift Container Platform	Reporter:	Yang Yang <yanyang>
Component:	Installer	Assignee:	Patrick Dillon <padillon>
Installer sub component:	openshift-installer	QA Contact:	Yang Yang <yanyang>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	adahiya, padillon, yanyang
Version:	4.3.0
Target Milestone:	---
Target Release:	4.4.0
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: survey message says to use space to select Consequence: pressing space bar filters message based on space, not to select Fix: change error message to say select with enter Result: incorrect message is no longer displayed	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-13 21:52:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yang Yang 2019-11-19 10:05:37 UTC

Description of problem:
During OCP installing on GCP using installer, an error occures when following below prompts to select platform GCP using space, however, enter works. The issue also happens on Region selection.

? Platform    [Use arrows to move, space to select, type to filter" 

Version-Release number of the following components:
openshift-install-linux-4.3.0-0.nightly-2019-11-18-175710

How reproducible:
100%

Steps to Reproduce:
1. Issue the following cli to install a cluster on GCP
./openshift-install create cluster --dir=./gcp_cluster --log-level=debug

2. Navigate to platform page, move to gcp
? Platform  [Use arrows to move, space to select, type to filter, ? for more help] 
  aws 
  azure 
> gcp 
  openstack 

3. Use space to select

4. Use enter to move on

Actual results:
An error occurs when using space to select platform. However enter works. The issue also happens on region selection.

X Sorry, your reply was invalid: Value is required 
? Platform  [Use arrows to move, space to select, type to filter, ? for more help] 
> aws 
  azure 
  gcp 
  openstack 

Expected results:

Space works well if keeping the prompts unchanged. Alternatively, change the prompts to ? Platform  [Use arrows to move, enter to select, type to filter, ? for more help]

Additional info:

Comment 1 Yang Yang 2019-11-20 05:59:18 UTC

The issue also happens on Base Domain selection.

Comment 2 Patrick Dillon 2019-11-20 14:44:20 UTC

This is an upstream bug in the prompt. Not sure how we track those in BZ. I created https://github.com/AlecAivazis/survey/pull/260 to remedy.

Comment 3 Scott Dodson 2019-12-02 15:11:18 UTC

(In reply to Patrick Dillon from comment #2)
> This is an upstream bug in the prompt. Not sure how we track those in BZ. I
> created https://github.com/AlecAivazis/survey/pull/260 to remedy.

Just leave this bug open and track that PR. If it becomes clear that it may not merge for some reason we'll decide what to do about it.

Comment 4 Abhinav Dahiya 2020-01-29 01:07:57 UTC

https://github.com/AlecAivazis/survey/pull/260

merged..so we should update our vendored version

Comment 5 Patrick Dillon 2020-02-06 01:59:44 UTC

The prior PR was to V2, which requires Go modules. I created a PR to cherry-pick back to V1: https://github.com/AlecAivazis/survey/pull/269

Comment 7 Yang Yang 2020-02-14 03:26:34 UTC

Verified with 4.4.0-0.nightly-2020-02-13-212616

[root@preserve-yangyangmerrn-1 build]# openshift-install create install-config --dir=test
? SSH Public Key  [Use arrows to move, enter to select, type to filter, ? for mo? SSH Public Key  [Use arrows to move, enter to select, type to filter, ? for mo? SSH Public Key /root/.ssh/id_rsa.pub
? Platform  [Use arrows to move, enter to select, type to filter, ? for more hel? Platform  [Use arrows to move, enter to select, type to filter, ? for more hel? Platform  [Use arrows to move, enter to select, type to filter, ? for more hel? Platform gcp
INFO Credentials loaded from file "/root/.gcp/osServiceAccount.json" 
? Project ID openshift-qe
? Region us-central1
? Base Domain  [Use arrows to move, enter to select, type to filter, ? for more ? Base Domain qe.gcp.devcluster.openshift.com
? Cluster Name [? for help] 

Prompt use enter to make selection hence moving it to verified state.

Comment 9 errata-xmlrpc 2020-05-13 21:52:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581