Bug 1773922

Summary:	remote-viewer prompts for password after migration of a VM with expired ticket
Product:	[oVirt] vdsm	Reporter:	Radek Duda <rduda>
Component:	Core	Assignee:	Milan Zamazal <mzamazal>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Qin Yuan <qiyuan>
Severity:	medium	Docs Contact:
Priority:	high
Version:	4.40.40	CC:	ahadas, bugs, lsurette, mtessun, spice-qe-bugs, srevivo, tpelka, uril, victortoso, vtosodec, ycui
Target Milestone:	ovirt-4.4.5	Keywords:	Regression, Triaged
Target Release:	4.40.50.1	Flags:	pm-rhel: ovirt-4.4+ ahadas: blocker- pm-rhel: planning_ack+ ahadas: devel_ack+ pm-rhel: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	vdsm-4.40.50.1-1	Doc Type:	Bug Fix
Doc Text:	When migrating a VM with an open remote-viewer console, the console ticket wasn't updated. This could result in making the console connection invalid after the migration and the need to close the console and open it again in order to keep using it. It has been fixed and the console ticket is still valid after a migration now.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-18 15:14:45 UTC	Type:	Feature Request
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Radek Duda 2019-11-19 10:44:52 UTC

Description of problem:
When VM with expired password from console.vv file is migrated, remote-viewer prompts user for it. In most cases user does not possess this password since console.vv file is already deleted (by default). So reconnecting to VM by newly generated console.vv file seems as the only solution. Not user-friendly at all.

Version-Release number of selected component (if applicable):
client: rhel7.8
spice-gtk3-0.35-5.el7
virt-viewer-5.0-17.el7

host:
spice-server-0.14.0-7.el7.x86_64

migration performed on 
RHV4.3
ovirt-engine-4.3.7.2-0.1.el7.noarch

How reproducible:
always

Steps to Reproduce:
1.Connect to VM with remote-viewer console.vv
2. Wait 120s till password from console.vv file expires
3. Migrate VM to the other host in RHV

Actual results:
User is prompted for password

Expected results:
No need to prompt user for password. Password is preserved across migration/spice sessions.

Additional info:
See https://bugzilla.redhat.com/show_bug.cgi?id=1761776 for more details.

Comment 6 Frediano Ziglio 2020-10-08 14:00:59 UTC

I did a test with RHV. It happens even there, the client is asking the password, even with seamless migration. If you connect and then quickly migrate password is not asked.

Comment 7 Frediano Ziglio 2020-10-12 14:33:34 UTC

One idea from Uri is to have RHV set a new ticket on both source and destination.
If server could send new ticket to client (this requires changes to protocol and support in both server and client) this would remove the need to ask user a password.
So this would require changes to: server, client, RHV.

Comment 8 Uri Lublin 2020-10-22 12:35:16 UTC

Additional to comment #7:
- I think RHV should set the ticket on the destination
- I think RHV used to do it
- I tested locally [single host, with qemu-kvm command line]
  with TLS+password, and it worked for me

Comment 9 Uri Lublin 2020-12-13 13:10:48 UTC

Upstream patch posted: https://gerrit.ovirt.org/c/vdsm/+/112607

Comment 11 RHEL Program Management 2020-12-13 17:21:58 UTC

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 12 Qin Yuan 2021-02-10 10:14:21 UTC

Verified with:
vdsm-4.40.50.4-1.el8ev.x86_64
ovirt-engine-4.4.5.4-0.6.el8ev.noarch

Steps:
1. Create and run a VM, connect to VM console via remote-viewer
2. Wait 120s
3. Migrate the VM

Result:
The console connection is still alive after VM migration.

Comment 13 Sandro Bonazzola 2021-03-18 15:14:45 UTC

This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.