Bug 1775050 (CVE-2019-19057)

Summary: CVE-2019-19057 kernel: Two memory leaks in the mwifiex_pcie_init_evt_ring() function in drivers/net/wireless/marvell/mwifiex/pcie.c allows for a DoS
Product: [Other] Security Response Reporter: Marian Rehak <mrehak>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: unspecifiedCC: acaringi, airlied, bdettelb, bhu, blc, brdeoliv, bskeggs, dhoward, dvlasenk, esammons, fhrbata, hdegoede, hkrzesin, iboverma, ichavero, itamar, jarodwilson, jeremy, jforbes, jglisse, jlelli, john.j5live, jonathan, josef, jross, jschorr, jshortt, jstancek, jwboyer, kernel-maint, kernel-mgr, labbott, lgoncalv, linville, masami256, matt, mchehab, mcressma, mjg59, mlangsdo, nmurray, plougher, pmatouse, qzhao, rt-maint, rvrbovsk, steved, williams, wmealing
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Two memory leak flaws were found in the Linux kernel's mwifiex_pcie_init_evt_ring() function. A local attacker, able to reload the kernel module or hotplug Marvell WiFi hardware using this driver, can cause a denial of service (memory consumption) by triggering mwifiex_map_pci_memory() failures.
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-28 16:34:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1775051, 1776600, 1776601, 1776602, 1781531, 1781534    
Bug Blocks: 1775052    

Description Marian Rehak 2019-11-21 11:40:59 UTC
Two memory leaks in the mwifiex_pcie_init_evt_ring() function in drivers/net/wireless/marvell/mwifiex/pcie.c in the Linux kernel through 5.3.11 allow attackers to cause a denial of service (memory consumption) by triggering mwifiex_map_pci_memory() failures.

Upstream Issue:

https://github.com/torvalds/linux/commit/d10dcb615c8e29d403a24d35f8310a7a53e3050c

Comment 1 Marian Rehak 2019-11-21 11:41:21 UTC
Created kernel tracking bugs for this issue:

Affects: fedora-all [bug 1775051]

Comment 2 Wade Mealing 2019-11-26 04:15:47 UTC
My initial findings show that this is only on bringing up the device, not on a regular interval. It is definitely wasted memory if device bringup fails and triggers the flaw, but I don't imagine this is a big impact flaw.

Comment 15 Wade Mealing 2019-12-16 03:54:44 UTC
The affected function mwifiex_pcie_init_evt_ring

Which is called in two possible ways.

mwifiex_init_pcie()
   -> mwifiex_pcie_alloc_buffers()
    -> mwifiex_pcie_create_evtbd_ring()
     -> mwifiex_pcie_init_evt_ring()

mwifiex_pcie_up_dev() 
   -> mwifiex_pcie_alloc_buffers()
    -> mwifiex_pcie_create_evtbd_ring()
     -> mwifiex_pcie_init_evt_ring()

Both of these functions are used during PCIE device initialization time, with no network traffic existing on the card at this time.  Other reports may show this as a network based attack however as this issue is during the hardware initialization the network attack vector is not correct.

Comment 16 errata-xmlrpc 2020-04-28 15:25:16 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 8

Via RHSA-2020:1567 https://access.redhat.com/errata/RHSA-2020:1567

Comment 17 errata-xmlrpc 2020-04-28 15:51:47 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 8

Via RHSA-2020:1769 https://access.redhat.com/errata/RHSA-2020:1769

Comment 18 Product Security DevOps Team 2020-04-28 16:34:52 UTC
This bug is now closed. Further updates for individual products will be reflected on the CVE page(s):

https://access.redhat.com/security/cve/cve-2019-19057