Bug 1775445

python-jupymake please [https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_general_naming].

Please change name to lowercase.

Issues:
=======
- Package contains BR: python2-devel or python3-devel
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies
says
> Packages building for Python 3 will need BuildRequires: python3-devel.

- Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
  Note: Package contains %{pythonX_site(lib|arch)}/* in %files
  See: https://pagure.io/packaging-committee/issue/782
Yep, please switch to a more specific pattern.

(In reply to Zbigniew Jędrzejewski-Szmek from comment #2)
> Please change name to lowercase.

Done.

> Issues:
> =======
> - Package contains BR: python2-devel or python3-devel
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> #_dependencies
> says
> > Packages building for Python 3 will need BuildRequires: python3-devel.

Ha, that's funny.  We have dueling packaging guidelines.  The spec file contains:

BuildRequires: pkgconfig(python3)

because of the packaging guideline that says you have to use the pkgconfig(foo) variant when it is available ... which it is with python3-devel.  So I think the python guidelines will have to be updated to say that you must BR pkgconfig(python2) or pkgconfig(python3).

> - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
>   Note: Package contains %{pythonX_site(lib|arch)}/* in %files
>   See: https://pagure.io/packaging-committee/issue/782
> Yep, please switch to a more specific pattern.

Oops, that was an oversight.  I generated the spec file with rpmdev-newspec, which put that glob there.  I saw it and intended to make it more specific, but forgot.  New URLs:

Spec URL: https://jjames.fedorapeople.org/python-jupymake/python-jupymake.spec
SRPM URL: https://jjames.fedorapeople.org/python-jupymake/python-jupymake-0.9-1.20190509.031cc3a.fc32.src.rpm
RPMLINTRC URL: https://jjames.fedorapeople.org/python-jupymake/python-jupymake.rpmlintrc

I always interpreted this that the pkgonfig guidelines don't apply in this case, because
https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/
says
> Fedora packages which use pkg-config to build against a library
and here neither pkg-config is used, nor are just building against a library.
For example, the python3-devel package might provide the python3_foo or py_project
macros and other stuff required even for non-compiled python projects.
Also, language-specific rules would trump general guidelines.

> Spec URL: https://jjames.fedorapeople.org/python-jupymake/python-jupymake.spec
404 :(

Good grief.  This might almost be comical if it wasn't so embarrassing.  The URLs should be valid now.  I forgot to rename the enclosing directory from python-JuPyMake to python-jupymake.  And the spec file contains BR: python3-devel.

+ package name is OK
+ license is acceptable (GPLv2+)
+ license is specified correctly
+ builds and installs OK
+ Provides/BR/R look OK

rpmlint has nothing useful.

Package is APPROVED.

Thank you for your patience.  I appreciate the review.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-jupymake

FEDORA-2019-b9d4340b95 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b9d4340b95

cocoalib-0.99650-1.fc31, giac-1.5.0.63-4.fc31, normaliz-3.8.3-1.fc31, polymake-3.6-1.fc31, python-jupymake-0.9-1.20190509.031cc3a.fc31, python-jupyter-polymake-0.16-11.20180129.7049940.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b9d4340b95

FEDORA-2019-b9d4340b95 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b9d4340b95

Singular-4.1.1p3-10.fc31, cocoalib-0.99650-1.fc31, giac-1.5.0.63-4.fc31, normaliz-3.8.3-1.fc31, polymake-3.6-1.fc31, python-jupymake-0.9-1.20190509.031cc3a.fc31, python-jupyter-polymake-0.16-11.20180129.7049940.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b9d4340b95

FEDORA-2019-b9d4340b95 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b9d4340b95

Singular-4.1.1p3-10.fc31, cocoalib-0.99650-1.fc31, giac-1.5.0.75-2.fc31, normaliz-3.8.3-1.fc31, polymake-3.6-1.fc31, python-jupymake-0.9-1.20190509.031cc3a.fc31, python-jupyter-polymake-0.16-11.20180129.7049940.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b9d4340b95

Singular-4.1.1p3-10.fc31, cocoalib-0.99650-1.fc31, giac-1.5.0.75-2.fc31, normaliz-3.8.3-1.fc31, polymake-3.6-1.fc31, python-jupymake-0.9-1.20190509.031cc3a.fc31, python-jupyter-polymake-0.16-11.20180129.7049940.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.