Bug 1775449

Summary:	node tuning operator lacking "script" plug-in for tuned profiles
Product:	OpenShift Container Platform	Reporter:	Andrew Theurer <atheurer>
Component:	Node Tuning Operator	Assignee:	Jiří Mencák <jmencak>
Status:	CLOSED NOTABUG	QA Contact:	Simon <skordas>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.3.0	CC:	fsimonce, mtosatti, sejug, yquinn, zkosic
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-29 08:29:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1812894
Bug Blocks:

Description Andrew Theurer 2019-11-22 01:37:20 UTC

Description of problem:

Need to support "script" plug-in for node tuning operator


There exist tuned profiles which use the "script" plug-in to complete various tunings. For example cpu-partitioning uses script to update irqbalance and create files for a tuned initrd:  https://github.com/redhat-performance/tuned/blob/master/profiles/cpu-partitioning/script.sh

We need functionality like this if we want to support more tuned profiles like cpu-partitioning and realtime, which are critical for Telco usage.

Comment 1 Zvonko Kosic 2019-11-26 18:48:25 UTC

Andrew, which profiles are we considering here to be enabled? Are you considering to write your own or rely only the existing one?

Comment 3 Andrew Theurer 2019-12-02 16:18:07 UTC

(In reply to Zvonko Kosic from comment #1)
> Andrew, which profiles are we considering here to be enabled? Are you
> considering to write your own or rely only the existing one?

I think we would write a new profile, but we need some of the functionality we see in cpu-partitioning's script.sh:

1) irqbalance_banned_cpus_setup: set up banned_cpus variable in irqbalance and restart it
2) Adding things to 2nd initrd:
-systemd: set up CPUaffinity
-00-tuned-pre-udev.sh: script to tuned kernel very early in boot process

If these things can be handled without a script plug-in, then maybe we don't need to support script plug-in explicitly.

Comment 5 Marcelo Tosatti 2019-12-06 18:19:00 UTC

(In reply to Andrew Theurer from comment #3)
> (In reply to Zvonko Kosic from comment #1)
> > Andrew, which profiles are we considering here to be enabled? Are you
> > considering to write your own or rely only the existing one?
> 
> I think we would write a new profile, but we need some of the functionality
> we see in cpu-partitioning's script.sh:
> 
> 1) irqbalance_banned_cpus_setup: set up banned_cpus variable in irqbalance
> and restart it

A tuned should take care of this internally.

> 2) Adding things to 2nd initrd:
> -systemd: set up CPUaffinity

And again a tuned profile should take care of this internally.

> -00-tuned-pre-udev.sh: script to tuned kernel very early in boot process
> 
> If these things can be handled without a script plug-in, then maybe we don't
> need to support script plug-in explicitly.

Comment 8 Jiří Mencák 2020-02-06 13:55:26 UTC

Andrew, I believe what you are asking is writing container compatible profiles for tuned which do not use the script plugin or at least make sure they work on RHCOS too.  Can this BZ be closed or made into a more specific one?  Thanks.

Comment 11 Jiří Mencák 2020-05-29 08:29:30 UTC

Closing as this is an RFE tracked internally by Jira cards.

Comment 12 Red Hat Bugzilla 2023-09-14 05:47:24 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days