Bug 177603

Summary: Review Request: libpri
Product: [Fedora] Fedora Reporter: Jeffrey C. Ollie <jeff>
Component: Package ReviewAssignee: David Woodhouse <dwmw2>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: erik.labianca, ghenry, matthias, shiva, somlo, steve, tjb
Target Milestone: ---Flags: kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-10-15 03:59:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 177584    
Bug Blocks: 163779, 178922    

Description Jeffrey C. Ollie 2006-01-12 05:01:35 UTC
Spec Name or Url: http://www.ocjtech.us/libpri-1.2.1-1.spec
SRPM Name or Url: http://www.ocjtech.us/libpri-1.2.1-1.src.rpm
Description: 

libpri is a C implementation of the Primary Rate ISDN specification.
It was based on the Bellcore specification SR-NWT-002343 for National
ISDN.  As of May 12, 2001, it has been tested work with NI-2, Nortel
DMS-100, and Lucent 5E Custom protocols on switches from Nortel and
Lucent.

Comment 1 Gabriel Somlo 2006-01-12 14:35:54 UTC
> Source0: http://ftp.digium.com/pub/libpri/libpri-%{version}.tar.gz

Source0: http://ftp.digium.com/pub/libpri/%{name}-%{version}.tar.gz

> BuildRoot: %{_tmppath}/%{name}-buildroot

BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

> rm -rf $RPM_BUILD_ROOT

use %{buildroot} instead of $RPM_BUILD_ROOT

> %changelog
> * Mon Apr 11 2005 Jeffrey C. Ollie <jcollie.dmacc.edu> - 1.0.7-0.3

You're up to version 1.2.1-1, so are you missing some changelog entries ?

Comment 2 Ignacio Vazquez-Abrams 2006-01-12 14:45:33 UTC
(In reply to comment #1)
> > rm -rf $RPM_BUILD_ROOT
> 
> use %{buildroot} instead of $RPM_BUILD_ROOT

Both are acceptable. The only requirement is to be consistent throughout the
spec file, which is the case here.

Comment 3 Jeffrey C. Ollie 2006-01-12 15:15:49 UTC
Update Spec/SRPM:

Spec Name or Url: http://www.ocjtech.us/libpri-1.2.1-2.spec
SRPM Name or Url: http://www.ocjtech.us/libpri-1.2.1-2.src.rpm

I also fixed a number of issues that I noticed after getting a good night's sleep.

Comment 4 Jeffrey C. Ollie 2006-01-12 18:42:56 UTC
Updated Spec/SRPM:

Spec Name or Url: http://www.ocjtech.us/libpri-1.2.1-3.spec
SRPM Name or Url: http://www.ocjtech.us/libpri-1.2.1-3.src.rpm

Fixes building on 64 bit systems.


Comment 5 Paul P Komkoff Jr 2006-01-13 06:17:57 UTC
Maybe something like this
%{__perl} -pi -e 's|\$\(INSTALL_BASE\)/lib|%{_libdir}|g' Makefile
will be easier to maintain than additional patch file? Digium folks are knowh by
randomly changing layout of their makefiles...

Comment 6 Paul P Komkoff Jr 2006-01-13 06:21:59 UTC
P.S. This is the specfile I'm using in my installations:
http://stingr.net/l/libpri.spec

Comment 7 Jeffrey C. Ollie 2006-01-13 14:52:11 UTC
Updated Spec/SRPM:

Spec Name or Url: http://www.ocjtech.us/libpri-1.2.1-4.spec
SRPM Name or Url: http://www.ocjtech.us/libpri-1.2.1-4.src.rpm

Fixes issues from comment #5 and picks up a few tips from the spec linked in #6.


Comment 8 Paul P Komkoff Jr 2006-01-15 18:13:25 UTC
Please fix my last name spelling :) thanks.

Comment 9 Jeffrey C. Ollie 2006-01-19 02:51:08 UTC
Updated Spec/SRPM:

Spec Name or Url: http://www.ocjtech.us/libpri-1.2.2-1.spec
SRPM Name or Url: http://www.ocjtech.us/libpri-1.2.2-1.src.rpm

* Wed Jan 18 2006 Jeffrey C. Ollie <jeff> - 1.2.2-1
- Update to 1.2.2.
- Fix the spelling of Paul Komkoff Jr.'s name.

Comment 10 Matthias Saou 2006-03-29 12:25:58 UTC
Suggestions:
- Remove the trailing dot of the devel summary.
- Change the main summary to something like :
  "Implementation of the Primary Rate ISDN specification" or
  "Primary Rate ISDN library"
- You might want to include the ChangeLog and the TODO in %doc.

All the rest looks good indeed.

Comment 11 Erik S. LaBianca 2006-08-09 21:08:11 UTC
http://www.ocjtech.us/libpri-1.2.2-1.src.rpm seems to be an out of date url, is
there a more up to date one?

Comment 15 David Woodhouse 2006-10-14 09:40:18 UTC
Versioning: libpri-1.4.0-1.fc6.beta1 < libpri-1.4.0-1.fc6
Make it -0.fc6.beta1 like you did zaptel.


W: libpri-devel summary-ended-with-dot Development files for libpri.

Fix those two and it's fine. Approving...


Comment 16 David Woodhouse 2006-10-14 09:45:50 UTC
Oh, and you can drop the BR: zaptel-devel since you're not actually building the
test binaries which actually use it. libpri itself doesn't.

Comment 17 Jeffrey C. Ollie 2006-10-15 03:59:34 UTC
Imported and built for FE development with the recommended changes.  Branch for
FE-5 requested.

Comment 18 Matthias Saou 2006-10-25 10:04:53 UTC
(In reply to comment #15)
> Versioning: libpri-1.4.0-1.fc6.beta1 < libpri-1.4.0-1.fc6
> Make it -0.fc6.beta1 like you did zaptel.

Both are wrong :-(
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d2288206ac9bd8f1bf9b791b22a

Comment 19 Will Tatam 2007-10-10 19:57:56 UTC
where have the SRPMS gone ?

Comment 20 Jeffrey C. Ollie 2007-10-10 20:07:27 UTC
libpri is part of Fedora now so you should be able to find the SRPMs on your
local Fedora mirror.  Or you could install the libpri and libpri-devel packages
directly using yum.

Comment 21 Jeffrey C. Ollie 2007-11-03 18:20:25 UTC
Package Change Request
======================
Package Name: libpri
New Branches: EL-5
Updated EPEL Owners: jcollie

Needed to build Asterisk package on EL-5.

Comment 22 Kevin Fenzi 2007-11-03 19:32:06 UTC
cvs done.