Bug 1776599

Summary:	Can't parse line break in the secret that conduce imagestreams import failed
Product:	OpenShift Container Platform	Reporter:	XiuJuan Wang <xiuwang>
Component:	ImageStreams	Assignee:	Oleg Bulatov <obulatov>
Status:	CLOSED ERRATA	QA Contact:	XiuJuan Wang <xiuwang>
Severity:	low	Docs Contact:
Priority:	low
Version:	4.3.0	CC:	adam.kaplan, akostadi, aos-bugs, gmontero, jokerman, obulatov, wzheng
Target Milestone:	---	Keywords:	Regression
Target Release:	4.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: to detect if base64 is padded or unpadded the decoder was relying on the string length Consequence: the decoder was not able to handle pull secrets that contain whitespaces Fix: check if the string has trailing padding symbols instead Result: pull secrets with whitespaces can be used to pull images	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-04 11:17:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Comment 4 Oleg Bulatov 2019-11-27 16:50:05 UTC

Fix for upstream: https://github.com/kubernetes/kubernetes/pull/85687

Comment 5 Adam Kaplan 2019-12-02 18:39:05 UTC

Marking this as a 4.4 bugfix - Oleg's PR merged upstream, with cherrypick to 1.17.

Comment 6 XiuJuan Wang 2020-01-06 07:03:47 UTC

This bug is found with invalid secret, mark it to low.

Comment 8 XiuJuan Wang 2020-01-09 09:38:58 UTC

Test with 4.4.0-0.nightly-2020-01-08-194939
Could parse secret with line break, and related imagestreams import successfully.

Comment 10 errata-xmlrpc 2020-05-04 11:17:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581