Bug 1777394

Summary: networkInterfaceMultiqueue triggers validation error
Product: Container Native Virtualization (CNV) Reporter: Filip Krepinsky <fkrepins>
Component: NetworkingAssignee: oshoval
Status: CLOSED NOTABUG QA Contact: Meni Yakove <myakove>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.1.0CC: cnv-qe-bugs, ncredi, oshoval, phoracek
Target Milestone: ---   
Target Release: 2.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-02 11:46:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
rhel.template.yaml
none
rhel.vm.yaml
none
base template none

Description Filip Krepinsky 2019-11-27 15:11:50 UTC
Created attachment 1640137 [details]
rhel.template.yaml

Description of problem:
Following validation error is returned when trying to create a VM from attached template

Error "MultiQueue for network interfaces can't be used without specifying CPU requests or limits." for field "spec.template.spec.domain.devices.networkInterfaceMultiqueue

Version-Release number of selected component (if applicable):
Client Version: openshift-clients-4.3.0-201910250623-66-g386b42b6
Server Version: 4.3.0-0.nightly-2019-11-21-122827
Kubernetes Version: v1.16.2

How reproducible:
100

Workaround
deleting the networkInterfaceMultiqueue field

Comment 1 Filip Krepinsky 2019-11-27 15:13:36 UTC
Created attachment 1640138 [details]
rhel.vm.yaml

also attaching the failed vm

Comment 2 Petr Horáček 2019-11-28 11:10:24 UTC
Or, could you please investigate this? What raises the issue and how can we solve it? Do we need to fix something in kubevirt core or just in the template?

Comment 4 Filip Krepinsky 2019-11-28 13:34:54 UTC
this was tested with 2.1 hco 
- the original v0.6.2 common templates work fine (they do not have networkInterfaceMultiqueue field)
- the newer 0.7.0 common templates showcase this behaviour

Comment 5 oshoval 2019-11-28 13:36:29 UTC
tried with 2.2
a base template (will attach it) and the vm itself
the create of both was fine

then if i try  virtctl start rhel81 (or oc edit vm rhel81 and set running to true)
i get

[root@modi01 kubevirtci-ocp-providers]# virtctl start rhel81 Error starting VirtualMachine an error on the server ("admission webhook \"virt-template-admission.kubevirt.io\" denied the request: invalid character ']' looking for beginning of value: {\"spec\":{\"running\": true}}") has prevented the request from succeeding

Comment 6 oshoval 2019-11-28 13:37:24 UTC
Created attachment 1640352 [details]
base template

Comment 8 Filip Krepinsky 2019-11-28 14:17:03 UTC
yup it is broken in 2.1
- it is enough to use 0.6.2 common templates with added networkInterfaceMultiqueue field

but apparently it works for oshoval in 2.2

Comment 9 Petr Horáček 2019-11-29 16:40:22 UTC
Is 2.1 supposed to work with 0.7.0 templates?

I'm trying to figure out whether we need to verify anything or this was just a mismatch of used versions.

Comment 10 Filip Krepinsky 2019-12-02 11:46:37 UTC
Closing, it seems it was just mismatched version.