Bug 1777512
| Summary: | Cannot create OVS patch port via tripleo heat templates due to sed command in run-os-net-config.sh | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | david.waddell |
| Component: | openstack-tripleo-heat-templates | Assignee: | Nate Johnston <njohnston> |
| Status: | CLOSED ERRATA | QA Contact: | Sasha Smolyak <ssmolyak> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 13.0 (Queens) | CC: | amoralej, bcafarel, jamsmith, mburns, njohnston, skaplons |
| Target Milestone: | --- | Keywords: | Triaged, ZStream |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | openstack-tripleo-heat-templates-8.4.1-32.el7ost | Doc Type: | No Doc Update |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-03-10 11:23:19 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
apologies slight typo in above - the required change is
diff /usr/share/openstack-tripleo-heat-templates/network/scripts/run-os-net-config.sh.bak /usr/share/openstack-tripleo-heat-templates/network/scripts/run-os-net-config.sh
132c132
< sed -i "s/bridge_name/${bridge_name:-''}/" /etc/os-net-config/config.json
---
> sed -i "s/: \"bridge_name/: \"${bridge_name:-''}/" /etc/os-net-config/config.json
Added upstream fix https://review.opendev.org/696898 Fix merged in upstream master; backported it back to stable/queens. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:0760 |
Description of problem: An OVS patch port can specified in tripleo nic templates e.g - type: ovs_bridge name: br-tenant use_dhcp: false - type: ovs_patch_port name: patch-ex-tenant bridge_name: br-tenant peer: patch-tenant-ex - type: ovs_patch_port name: patch-tenant-ex bridge_name: br-ex peer: patch-tenant which is rendered in json for os-net-config as this { "type": "ovs_patch_port", "peer": "patch-tenant-ex", "name": "patch-ex-tenant", "bridge_name": "br-tenant" }, { "type": "ovs_patch_port", "peer": "patch-tenant", "name": "patch-tenant-ex", "bridge_name": "br-ex" } however the tripleo script run-os-netconfig.sh script replaces 'bridge_name' with br-ex|br-storage using a sed command. this needs updating as follows to ensure it only selects bridge_name as a value, not as a key, in the json script. $ diff /usr/share/openstack-tripleo-heat-templates/network/scripts/run-os-net-config.sh.bak /usr/share/openstack-tripleo-heat-templates/network/scripts/run-os-net-config.sh 132c132 < sed -i "s/bridge_name/${bridge_name:-''}/" /etc/os-net-config/config.json --- > sed -i "s/: bridge_name/: ${bridge_name:-''}/" /etc/os-net-config/config.json Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: