Bug 1778105

Summary: CVE-2018-20060 python3-virtualenv: python-urllib3: Cross-host redirect does not remove Authorization header allow for credential exposure [epel-7]
Product: [Fedora] Fedora EPEL Reporter: Tomas Hoger <thoger>
Component: python3-virtualenvAssignee: Lumír Balhar <lbalhar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: epel7CC: lbalhar, orion
Target Milestone: ---Keywords: Security, SecurityTracking
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-03 05:47:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1649153    

Description Tomas Hoger 2019-11-29 10:24:19 UTC
This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of epel-7.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When submitting as an update, use the fedpkg template provided in the next
comment(s).  This will include the bug IDs of this tracking bug as well as
the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
fedpkg commit message.

Comment 1 Tomas Hoger 2019-11-29 10:24:21 UTC
Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# low, medium, high, urgent (required)
severity=medium

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=1649153,1778105

# Description of your update
notes=Security fix for [PUT CVEs HERE]

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

Comment 2 Lumír Balhar 2020-01-14 14:06:56 UTC
Another CVE for bundled urllib3 fixed in the same way as the main python-urllib3 package.

This one is kinda special because pip is in virtualenv bundled in a form of a wheel which makes the application of the patches more complicated. Also, during testing, the PYTHONPATH has to be inside a virtual environment instead of system folders and the virtual environment has to be created with --no-download to prevent pip from upgrading.

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40524912

PR: https://src.fedoraproject.org/rpms/python3-virtualenv/pull-request/2

Verification (just on Python 3.4, 3.6 comes from the same sources):

python34-virtualenv-15.1.0-4
# PYTHONPATH=/venv/lib/python3.4/site-packages/pip/_vendor/requests/packages/ python3.4 poc.py 
/venv/lib/python3.4/site-packages/pip/_vendor/requests/packages/urllib3/connectionpool.py:838: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/security.html
  InsecureRequestWarning)

# python3.4 server.py
** HTTPS **
127.0.0.1 - - [14/Jan/2020 13:52:38] "GET / HTTP/1.1" 302 -
** PLAINTEXT **
127.0.0.1 - - [14/Jan/2020 13:52:38] mysecretvalue
127.0.0.1 - - [14/Jan/2020 13:52:38] "GET / HTTP/1.1" 200 -


python34-virtualenv-15.1.0-5
# PYTHONPATH=/venv/lib/python3.4/site-packages/pip/_vendor/requests/packages/ python3.4 poc.py
/venv/lib/python3.4/site-packages/pip/_vendor/requests/packages/urllib3/connectionpool.py:838: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/security.html
  InsecureRequestWarning)

# python3.4 server.py
** HTTPS **
127.0.0.1 - - [14/Jan/2020 13:56:25] "GET / HTTP/1.1" 302 -
** PLAINTEXT **
127.0.0.1 - - [14/Jan/2020 13:56:25] "GET / HTTP/1.1" 200 -