Bug 1778243

Summary:	s390utils: fix BLS-related decision logic in /usr/lib/kernel/install.d/*.install
Product:	Red Hat Enterprise Linux 8	Reporter:	Jan Hlavac <jhlavac>
Component:	s390utils	Assignee:	Dan Horák <dhorak>
Status:	CLOSED ERRATA	QA Contact:	Vilém Maršík <vmarsik>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.1	CC:	dhorak, rvr
Target Milestone:	rc
Target Release:	8.2
Hardware:	s390x
OS:	Linux
Whiteboard:
Fixed In Version:	s390utils-2.6.0-24.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-28 16:49:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Hlavac 2019-11-29 15:15:29 UTC

In the fix of the bug#1755899, there was introduced a change in the decision logic of the /usr/lib/kernel/install.d/20-zipl-kernel.install script. Specifically, whether the Boot Loader Specification (BLS) is used. Instead of just checking the existence of the /sbin/new-kernel-pkg file, the existence of the /boot/loader/entries directory is also checked.

More thorough testing revealed that the fix covers only the case when a new kernel is added. However, the remaining cases should also be covered. That means the case when a rescue kernel is added and the case when some kernel is removed.


Version-Release number of selected component:
s390utils-base-2.6.0-22.el8


Actual results:
When a rescue kernel is added or when some kernel is removed, the 52-zipl-rescue.install and 20-zipl-kernel.install scripts only check the existence of the /sbin/new-kernel-pkg file.


Expected results:
When a rescue kernel is added or when some kernel is removed, the 52-zipl-rescue.install and 20-zipl-kernel.install scripts check the existence of the /sbin/new-kernel-pkg file and the existence of the /boot/loader/entries directory.


Additional info:
A new fix already exists (bug#1755899 => attachment#1627629 [details]). It just needs to be rebased.

Comment 1 Vilém Maršík 2019-12-09 16:55:30 UTC

Is SanityOnly testing enough here?

Comment 2 Dan Horák 2019-12-10 18:43:57 UTC

Yes, it is. Later we can get feedback also from the in-place upgrade team, the original issue was their.

Comment 4 Vilém Maršík 2020-02-06 20:54:40 UTC

The fix looks applied to /usr/lib/kernel/install.d/20-zipl-kernel.install and /usr/lib/kernel/install.d/52-zipl-rescue.install in 8.2 Beta on s390x. Setting verified/sanityonly.

Comment 6 errata-xmlrpc 2020-04-28 16:49:37 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1826