Bug 1779490

Summary:	dns-node-resolver sometimes exits with status 255 on upgrade
Product:	OpenShift Container Platform	Reporter:	Clayton Coleman <ccoleman>
Component:	Networking	Assignee:	Clayton Coleman <ccoleman>
Networking sub component:	DNS	QA Contact:	Hongan Li <hongli>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	aos-bugs, dmace
Version:	4.3.0
Target Milestone:	---
Target Release:	4.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1779491 (view as bug list)		Environment:
Last Closed:	2020-05-04 11:18:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1779491

Description Clayton Coleman 2019-12-04 04:47:09 UTC

Dec 04 01:43:12.495 E ns/openshift-dns pod/dns-default-954mg node/ip-10-0-133-153.ec2.internal container=dns-node-resolver container exited with code 255 (Error): kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill -l [sigspec]\n

shows up fairly frequently in our upgrade logs.  This is caused when all the child pids exit before the trap command completes, causing kill to get no arguments.

The fix is fairly standard in similar scripts - use pipe to xargs -r kill to tolerate empty.

Comment 1 Hongan Li 2019-12-23 06:36:51 UTC

verified with 4.4.0-0.nightly-2019-12-20-210709 and issue has been fixed.

trap 'jobs -p | xargs kill || true; wait; exit 0' TERM

Comment 3 errata-xmlrpc 2020-05-04 11:18:30 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581