Bug 1779570

Can you please test upstream binary? (https://fedoraproject.org/wiki/How_to_debug_Firefox_problems?rd=Bug_info_Firefox#Testing_Mozilla_binaries)
If it's also broken there it should be moved upstream as we generally don't handle general extension breakage.

(In reply to Martin Stransky from comment #1)
> Can you please test upstream binary?

Interestingly, it works with upstream binary.

I tested the extension with my Firefox 71 on Fedora but it works. Maybe some profile corruption or so?

When I get back to FF70, the extension works, it does not work in F71. I think that something changed on storage side, not sure what :(

I could share the DB, there is nothing secret if it helps (but it has 90 MB :/ ).

And as I said, it work with upstream FF, but not with Fedora FF.

I see, Bug 1779082 may be related then.

Bug 1779762 is a similar one for Lastpass.

btw. can you test firefox-x11 package? It runs on X11 instead of on Wayland.

There is no difference with firefox-x11, IOW it doesn't work.

~~~
$ rpm -q firefox* -a
firefox-71.0-8.npgo.fc32.x86_64
firefox-x11-71.0-8.npgo.fc32.x86_64
~~~

BTW this is Brief upstream response from my ticket:

> tanriol commented 22 hours ago
>
> You may want to test with the Fedora binary, but still in a new profile. If it works, this may be some kind of profile corruption problem - these do happen in Firefox sometimes, especially on upgrades.
>
> tanriol commented 22 hours ago
> 
> The traceback here is not Brief-specific - this is not the Brief IDB instance, but the one Firefox uses internally for extension's storage.local storage area. Brief does use that one as a backup and assumes that is does work without problems.

Here's a report of Simple Tab Groups breaking with Firefox 71:
https://github.com/Drive4ik/simple-tab-groups/issues/500

And here is the root cause reported upstream:
https://bugzilla.mozilla.org/show_bug.cgi?id=1601365

I guess all these extensions will break due to the same issue. It doesn't seem to affect all distributions, though. There's an Arch user claiming he has no issues.

Also PrivacyBadger:
https://github.com/EFForg/privacybadger/issues/2474

Upstream issue:
https://bugzilla.mozilla.org/show_bug.cgi?id=1601424

Riot Web got broken after FF71 update
https://github.com/vector-im/riot-web/issues/11606

Riot Web is completely broken with FF71.

Riot logs:

Failed to flush logs :  
error { target: IDBRequest, isTrusted: true, srcElement: IDBRequest, currentTarget: IDBTransaction, eventPhase: 3, bubbles: true, cancelable: true, returnValue: true, defaultPrevented: false, composed: false, … }
rageshake.js:108:31
Unhandled rejection value/this.flushPromise</o.onerror@https://matrix.easycoding.org/bundles/b980657cd3d51f5fc3b5/bundle.js:40:89154
rageshake.js:108:31
Failed to flush logs :  
error { target: IDBRequest, isTrusted: true, srcElement: IDBRequest, currentTarget: IDBTransaction, eventPhase: 3, bubbles: true, cancelable: true, returnValue: true, defaultPrevented: false, composed: false, … }
rageshake.js:108:31
Unhandled rejection value/this.flushPromise</o.onerror@https://matrix.easycoding.org/bundles/b980657cd3d51f5fc3b5/bundle.js:40:89154
rageshake.js:108:31
Failed to flush logs :  
error { target: IDBRequest, isTrusted: true, srcElement: IDBRequest, currentTarget: IDBTransaction, eventPhase: 3, bubbles: true, cancelable: true, returnValue: true, defaultPrevented: false, composed: false, … }
rageshake.js:108:31
Unhandled rejection value/this.flushPromise</o.onerror@https://matrix.easycoding.org/bundles/b980657cd3d51f5fc3b5/bundle.js:40:89154
rageshake.js:108:31
Failed to flush logs :  
error { target: IDBRequest, isTrusted: true, srcElement: IDBRequest, currentTarget: IDBTransaction, eventPhase: 3, bubbles: true, cancelable: true, returnValue: true, defaultPrevented: false, composed: false, … }
rageshake.js:108:31
Unhandled rejection value/this.flushPromise</o.onerror@https://matrix.easycoding.org/bundles/b980657cd3d51f5fc3b5/bundle.js:40:89154
rageshake.js:108:31
Failed to flush logs :  
error { target: IDBRequest, isTrusted: true, srcElement: IDBRequest, currentTarget: IDBTransaction, eventPhase: 3, bubbles: true, cancelable: true, returnValue: true, defaultPrevented: false, composed: false, … }
rageshake.js:108:31
Unhandled rejection value/this.flushPromise</o.onerror@https://matrix.easycoding.org/bundles/b980657cd3d51f5fc3b5/bundle.js:40:89154
rageshake.js:108:31
Failed to flush logs :  
error { target: IDBRequest, isTrusted: true, srcElement: IDBRequest, currentTarget: IDBTransaction, eventPhase: 3, bubbles: true, cancelable: true, returnValue: true, defaultPrevented: false, composed: false, … }
rageshake.js:108:31
Unhandled rejection value/this.flushPromise</o.onerror@https://matrix.easycoding.org/bundles/b980657cd3d51f5fc3b5/bundle.js:40:89154
rageshake.js:108:31
Failed to flush logs :  
error { target: IDBRequest, isTrusted: true, srcElement: IDBRequest, currentTarget: IDBTransaction, eventPhase: 3, bubbles: true, cancelable: true, returnValue: true, defaultPrevented: false, composed: false, … }
rageshake.js:108:31
Unhandled rejection value/this.flushPromise</o.onerror@https://matrix.easycoding.org/bundles/b980657cd3d51f5fc3b5/bundle.js:40:89154
rageshake.js:108:31
Failed to flush logs :  
error { target: IDBRequest, isTrusted: true, srcElement: IDBRequest, currentTarget: IDBTransaction, eventPhase: 3, bubbles: true, cancelable: true, returnValue: true, defaultPrevented: false, composed: false, … }
rageshake.js:108:31
Unhandled rejection value/this.flushPromise</o.onerror@https://matrix.easycoding.org/bundles/b980657cd3d51f5fc3b5/bundle.js:40:89154
rageshake.js:108:31
Failed to flush logs :  
error { target: IDBRequest, isTrusted: true, srcElement: IDBRequest, currentTarget: IDBTransaction, eventPhase: 3, bubbles: true, cancelable: true, returnValue: true, defaultPrevented: false, composed: false, … }
rageshake.js:108:31
Unhandled rejection value/this.flushPromise</o.onerror@https://matrix.easycoding.org/bundles/b980657cd3d51f5fc3b5/bundle.js:40:89154
rageshake.js:108:31

Bitwarden extension is also affected. And even uBlock Origin. The easiest way to replicate is to simply install uBlock Origin, and then click on the toolbar icon for it so as to show its small window. The window will close on its own shortly when it should stay open until you close it.

The Tutanota mail app (not an extension) is also impacted. It throws frequent errors trying to update its local DB for searching the mailbox.

All of these cases work fine on Mozilla's official upstream build.

I tested just now with Fedora's Firefox and a new profile. I still see these problems.

Firefox 72 beta 2 is unaffected

It may be http://gcc.gnu.org/PR92831 and https://bugzilla.mozilla.org/show_bug.cgi?id=1601707

Three more extensions affected by this:

1. New Tab Tools
https://addons.mozilla.org/en-US/firefox/addon/new-tab-tools/

The local storage where tiles are stored cannot be read or updated. Interestingly enough, tiles that use custom images (also stored in my home folder) continue to display those images.


2. noturno
https://addons.mozilla.org/en-US/firefox/addon/noturno/

Proxy configuration cannot be read or set.


3. Proxy Switcher and Manager
https://addons.mozilla.org/en-US/firefox/addon/proxy-switcher-and-manager/

I had this one disabled because I was happy with noturno, but when I enabled it again, my settings had disappeared. I'm not sure how I got it to work, but it did, even though the toggle button seems to have stopped working and not all settings are retained.


I'm not 100% sure which build was the first to exhibit the problem, because I have been updating firefox from koji a lot lately, but I think that up to 71.0-6 there was no issue.

*** Bug 1779762 has been marked as a duplicate of this bug. ***

Interestingly, a user of Riot is reporting similar breakage on Debian (although not providing details so hard to be sure). See https://github.com/vector-im/riot-web/issues/11606#issuecomment-562576801

firefox-71.0-11.npgo.fc31.x86_64.rpm fixed the issue with New Tab Tools and Proxy Switcher and Manager, but I can't get noturno to work.
It's the same with firefox-71.0-12.clang.fc31.x86_64.rpm.

You can use .clang builds as a temporary workaround:
https://koji.fedoraproject.org/koji/packageinfo?packageID=37

(In reply to Martin Stransky from comment #23)
> You can use .clang builds as a temporary workaround:
> https://koji.fedoraproject.org/koji/packageinfo?packageID=37

I installed firefox-71.0-12.clang.fc31.x86_64 and while this solves the problem with the Tutanota site, there is still an issue with extensions. The windows for them continue to close on their own. However, Bitwarden at least doesn't lock too soon now. I wonder if there are multiple separate issues with the 71 release?

Yes, looks like we face different problems here, I do asan builds right now which can help to track memory issues.

(In reply to Martin Stransky from comment #25)
> Yes, looks like we face different problems here, I do asan builds right now
> which can help to track memory issues.

The x86_64 package is still being compiled. Once that's done, how do we use these builds to help?

There's still missing some fixes at recent builds, asan build crashes with:

SUMMARY: AddressSanitizer: stack-use-after-scope /home/komat/CVS/firefox/firefox-71.0/xpcom/string/nsTStringRepr.h:283 in mozilla::detail::nsTStringRepr<char>::IsDependentOn(char const*, char const*) const

Out of curiosity, is there no mechanism for dnf to backout an obviously broken version of an important application like this?  Three days seems like a long wait for such an important issue.

For end-users who just want to use firefox and extensions again,

To manually revert I used "dnf downgrade firefox", and edited "sudo vim /etc/dnf/dnf.conf" to exclude=firefox from upgrades, until the issue is fixed.

After restarting the downgraded firefox I did get some cache corruption errors from firefox that required the use of "Ctrl+Shift+R" to invalidate cache and reload the page again.

> Out of curiosity, is there no mechanism for dnf to backout an obviously broken version of an important application like this?  Three days seems like a long wait for such an important issue.

You can always downgrade to 70.0.1:

sudo dnf downgrade https://kojipkgs.fedoraproject.org/packages/firefox/70.0.1/4.fc31/x86_64/firefox-70.0.1-4.fc31.x86_64.rpm https://kojipkgs.fedoraproject.org//packages/firefox/70.0.1/4.fc31/x86_64/firefox-wayland-70.0.1-4.fc31.x86_64.rpm

Please check back to #1779762 - "Lastpass extension doesn't work with Firefox 71" as well. My recollection is that the greying-out of the extensions button (>>) was already present in 70 for the LastPass extension, but not always. 69 is reliable.

Root cause is tracked as https://bugzilla.mozilla.org/show_bug.cgi?id=1601707

Created attachment 1643157 [details]
Error log on console

I got same problem with LastPass plugin, 
I have to downgrade firefox by below command to make it works:
dnf downgrade firefox.x86_64

*** Bug 1780960 has been marked as a duplicate of this bug. ***

*** Bug 1779809 has been marked as a duplicate of this bug. ***

firefox-71.0-14.npgo at https://koji.fedoraproject.org/koji/packageinfo?packageID=37 should fix this.

I have installed firefox-71.0-14.npgo.fc31.x86_64 (I'm running it on X.org) and noturno is still broken. On the other hand, I had not encountered any startup crashes like the ones reported with previous versions. I will try to contact Athos Ribeiro for the issues with noturno.

firefox-71.0-14.npgo.fc31.x86_64 still has the minor problem that extension windows close by themselves. To repeat, Mozilla's official builds do not have this problem.

(In reply to Martin Stransky from comment #35)
> firefox-71.0-14.npgo at
> https://koji.fedoraproject.org/koji/packageinfo?packageID=37 should fix this.

Confirming that firefox-71.0-14.npgo fixes the crash at: mail.tutanota.com

Confirming that firefox-71.0-14.npgo fixes the LastPass login issue.

The build firefox-71.0-14.npgo has fixed my issues with LastPass and Tab for a Cause.

Thank you for a quick fix!

You may want to use fully optimized .15 builds:

https://koji.fedoraproject.org/koji/buildinfo?buildID=1420745
https://koji.fedoraproject.org/koji/buildinfo?buildID=1420744

Bodhi updates can't be submitted due to https://github.com/fedora-infra/bodhi/issues/3843

Brief works for me again testing with

~~~
$ rpm -q firefox
firefox-71.0-15.fc32.x86_64
~~~

Thx for the fix.

*** Bug 1779082 has been marked as a duplicate of this bug. ***

Hello,
  firefox-71.0-15.fc30.x86_64 seems to be fixing the problem for me. Thanks.

Yes, it will work for me also (using the brief extension).
Thanks.

Ditto, firefox-71.0-15.fc31.x86_64.rpm (from https://koji.fedoraproject.org/koji/buildinfo?buildID=1420745) fixes the issue with LastPass.

Hello,
firefox-71.0-15.fc30.x86_64 seems also to fix problems for me with Privacy Badger and missing QR code on messages.google.com

Hi. I confirm too that firefox-71.0-15.fc31.x86_64 fix the problem with KeepassXC.

Confirming that firefox-71.0-15.fc31.x86_64 fixed the issue with Simple Tab Groups

so... what now? When would this make it to fedora repos?

Actually, I think this is not a complete fix. 

I'm using LastPass and when I have multiple accounts listed for a site, the LastPass icon that appears in the userd and password field brings up a pulldown list of the accounts that are available for that site. Selecting one that is not the default should (and used to) replace the filled-in defaults with the form values corresponding to the selected account. That part is not working with firefox-71.0-15.fc31.x86_64. I can open the pulldown menu and select the account, but the fields are not updated.

FEDORA-2019-ab3dab5ba6 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ab3dab5ba6

firefox-71.0-15.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1b71789719

firefox-71.0-15.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

See comment 51. This version still doesn't correctly auto-fill forms from LastPass when the fill data is selected from multiple options via LastPass's pulldown list.

firefox-71.0-15.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

The build firefox-71.0-15.fc31.x86_64 fixed my problem with LastPass.

Thanks,

(In reply to Matthew Saltzman from comment #55)
> See comment 51. This version still doesn't correctly auto-fill forms from
> LastPass when the fill data is selected from multiple options via LastPass's
> pulldown list.

That may be a diffrent bug. Please try standard troubleshooting steps from
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems?rd=Bug_info_Firefox

FEDORA-FLATPAK-2019-2020e77e69 has been submitted as an update to Fedora 31 Flatpaks. https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2019-2020e77e69

(In reply to Martin Stransky from comment #58)
> (In reply to Matthew Saltzman from comment #55)
> > See comment 51. This version still doesn't correctly auto-fill forms from
> > LastPass when the fill data is selected from multiple options via LastPass's
> > pulldown list.
> 
> That may be a diffrent bug. Please try standard troubleshooting steps from
> https://fedoraproject.org/wiki/
> How_to_debug_Firefox_problems?rd=Bug_info_Firefox

Not sure what changed, but this seems to be OK now.

firefox-master-3120191220120626.1 has been pushed to the Fedora 31 Flatpaks testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2019-2020e77e69

firefox-master-3120191220120626.1 has been pushed to the Fedora 31 Flatpaks stable repository. If problems still persist, please make note of it in this bug report.

I know I am quite late to this one. I am noturno maintainer and the reason it was not working was due to the deprecation of part of the old proxy API. I rewrote part of noturno to address that and it should be working properly now.

(In reply to Athos Ribeiro from comment #63)
> I rewrote part of noturno to address that and it should be working properly
> now.

Hi Athos, it's been a while. Just as you were posting this, I got a notification to grant additional permissions to noturno, it's working fine now, thanks!