Bug 1779835

Summary:	unable to add ipsets to firewalld in ipv6 using brackets syntax
Product:	Red Hat Enterprise Linux 7	Reporter:	Richard Hyman <rhyman>
Component:	firewalld	Assignee:	Eric Garver <egarver>
Status:	CLOSED ERRATA	QA Contact:	Tomas Dolezal <todoleza>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.7	CC:	jmaxwell, todoleza
Target Milestone:	rc
Target Release:	7.9
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	firewalld-0.6.3-10.el7	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-29 19:21:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard Hyman 2019-12-04 20:24:40 UTC

Description of problem:

Submitting per customer request. This could really be defined as a bug or an RFE depending on your perspective on this. 

Unable to add ipsets with brackets per ipv6 RFC, using syntax such as[::2]

Version-Release number of selected component (if applicable):

Any version of RHEL 7 and 8 I was unable to add with brackets. Customer stated they were able to get it to work but did not specify a specific RHEL or Fedora release I was unable to get ipset addition with brackets to work on RHEL 7.7 or 8.1 

How reproducible:

Just about always in my experience. Customer states it works in some cases


Steps to Reproduce:
1. firewall-cmd --permanent --new-ipset=test --type=hash:net --option=family=inet6
2. firewall-cmd --permanent --ipset=test --add-entry=[::2] OR ipset add test [::2]
3.

Actual results:

(in my testing) 

[root@localhost ~]# firewall-cmd --permanent --ipset=test --add-entry=[::1]
Error: INVALID_ENTRY: invalid address '[::1]' in '[::1]' for hash:net (ipv6)


Expected results: success code such as:

[root@localhost ~]# firewall-cmd --permanent --ipset=test --add-entry=::1
success


Additional info:
 
Customer's reasoning is that per RFCs about ipv6 syntax use brackets and this implies that using brackets in ipv6 syntax is a standard that firewalld should adhere to.. I was not provided a specific RFC source from the customer but I found something that seemed vaugely relevant but not directly  https://tools.ietf.org/rfc/rfc2732.txt

Comment 6 Eric Garver 2020-02-27 15:13:34 UTC

Upstream:

  ff9cd7a4c618 ("test: ipset: coverage for ipv6 addresses with brackets")
  46065ddfacd2 ("fix: checkIP6: strip leading/trailing square brackets")

Comment 15 errata-xmlrpc 2020-09-29 19:21:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (firewalld bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3863