Bug 178021
Summary: | Review Request: SIBsim4 - Align expressed RNA sequences on a DNA template | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christian Iseli <Christian.Iseli> |
Component: | Package Review | Assignee: | Chris Chabot <chabotc> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | chabotc, fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-01-18 22:48:49 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Christian Iseli
2006-01-17 14:23:12 UTC
I'll pick it up, feel free to assign the bug to me, working on formal reviewlist now First few observations: Release 0, we start releases at '1' :-) Maybe better to use install -m664 for the manpage and -m755 for the binary? that way your always sure the file modes are correct. Compile failed for me, is there something i'm missing? (up to date fc-development-i386 box): gcc -o SIBsim4 -std=gnu99 -W -Wall -pedantic -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -fasynchronous-unwind-tables sim4b1.o align.o misc.o sim4.init.o sim4b1.o: In function `pluri_align':/usr/src/redhat/BUILD/SIBsim4-0.9/sim4b1.c:1315: undefined reference to `floor' collect2: ld returned 1 exit status make: *** [sim4] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.49523 (%build) man floor tells me this file should be linked with "-lm" to fix this error. Please correct the above errors (guidelines say package should atleast compile on fc devel), and post new src.rpm and i'll go thru the formar reviewlist. (In reply to comment #2) > Release 0, we start releases at '1' :-) Sure, but it is not unusual for review requests to start at 0... :-) > Maybe better to use install -m664 for the manpage and -m755 for the binary? Done. > Compile failed for me, is there something i'm missing? No, brain fart on my side (long story is that it works in some cases without the math lib due to compiler optimizations, but it all depends on the compiler switches used and on th etarget architecture...). Fixed. New spec and SRPMS are here: ftp://ftp.licr.org/pub/software/unix/SIBsim4.spec ftp://ftp.licr.org/pub/software/unix/SIBsim4-0.9-1.src.rpm Thanks! Looking good, package compiles perfectly for me now, rpmlint is quiet and mock is happy too. The formal review checklist: MUST review items: - Builds cleanly on FC5 devel. - Source included matches upsteam source (md5sum) - Package name meets guidelines - spec file name is in %{name}.spec format - Licence (GPL) is fedora extra's compatible & is included (COPYRIGHT) - Spec file is in (american) english - Does not list buildrequires that are excepted in the package guidelines - No build dependencies - No ldconfig needed - All files have proper permissions - Package is not relocatable - No duplicate files in %files section - No missing files in %files section - Has a proper %clean section with rm -rf $RPM_BUILD_ROOT - Uses macro's described in PackagingGuidelines - No entries in %doc that are required for standard program operation - No -devel package needed - No directory-ownerships needed - Not GUI app, no desktop file needed Should items: - Includes upstream licence(s) file - No insane scriplets - No unnescesarry requires - Mock builds cleanly Thanks for the quick updates! Package is FE-ACCEPTED Please cvs-import, make tag, make build and after this assign the bug to me please and close with NEXTRELEASE as resolution. (In reply to comment #4) > Thanks for the quick updates! Package is FE-ACCEPTED Thanks for the quick review :-) I changed the blocker... > Please cvs-import, make tag, make build Done. > and after this assign the bug to me please Was already done :) > and close with NEXTRELEASE as resolution. Done. Thanks. Woops sorry for that can't believe i forgot to change blocker bug. Happy .. umm .. dna sequencing? :-) np We don't do much sequencing here. Mainly data storage, distribution, and analysis :) |