Bug 1780267

Summary:	OSP16 \| collectd VIRT plugin installed on controller nodes which is wrong.
Product:	Red Hat OpenStack	Reporter:	Cédric Jeanneret <cjeanner>
Component:	puppet-tripleo	Assignee:	RHOS Maint <rhos-maint>
Status:	CLOSED ERRATA	QA Contact:	nlevinki <nlevinki>
Severity:	urgent	Docs Contact:
Priority:	high
Version:	16.0 (Train)	CC:	jhajyahy, jjoyce, jschluet, slinaber, tvignaud
Target Milestone:	beta	Keywords:	Triaged
Target Release:	16.0 (Train on RHEL 8.1)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	puppet-tripleo-11.3.1-0.20191206042811.fb14e26.el8ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-06 14:43:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Cédric Jeanneret 2019-12-05 15:36:27 UTC

This bug was initially created as a copy of Bug #1769872

I am copying this bug because: 
Need one for this component as well.


Basically the problem is that in the nova-compute-container-puppet.yaml should make that only where nova-compute together with collectd is deployed the tripleo.collectd.plugins.nova_compute hiera variable will be created

And this does not happen now.
So seems like services_config does not work any more.

service_config_settings:
        rsyslog:
          tripleo_logging_sources_nova_compute:
            - {get_param: NovaComputeLoggingSource}
        collectd:
          tripleo.collectd.plugins.nova_compute:
            - virt
          collectd::plugin::virt::connection: 'qemu:///system'

Comment 5 Jad Haj Yahya 2019-12-17 14:15:23 UTC

Checked the service_names hieradata by opening: /etc/puppet/hieradata/service_names.json
collectd does not exist on controller

Comment 8 errata-xmlrpc 2020-02-06 14:43:45 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:0283