Bug 1780823
| Summary: | Review Request: rinutils - headers-only c11/gnu11 used in Shlomi Fish's C projects | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shlomi Fish <shlomif> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review, quantum.analyst |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rinutils-0.1.4-1.fc32 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-08-03 00:25:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Shlomi Fish
2019-12-07 11:14:07 UTC
- Not needed:
rm -rf %buildroot
%defattr(-,root,root)
- Please use macro here:
%{_includedir}/%{basen}/*.h
- Please use librinutils as base package and add a -devel subpackage and add a
Provides: librinutils-static = %{version}-%{release}
See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries
(In reply to Robert-André Mauchin from comment #1) > - Not needed: > > rm -rf %buildroot > > %defattr(-,root,root) > > - Please use macro here: > > %{_includedir}/%{basen}/*.h > > - Please use librinutils as base package and add a -devel subpackage and > add a > > Provides: librinutils-static = %{version}-%{release} > > See > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_packaging_header_only_libraries Thanks! But for the life of me I cannot figure out how to make the main package "BuildArch: noarch" and the -devel package "BuildArch: "-plat-dependent. rpmlint warns on both cases where both are the same. (In reply to Shlomi Fish from comment #2) > (In reply to Robert-André Mauchin from comment #1) > > - Not needed: > > > > rm -rf %buildroot > > > > %defattr(-,root,root) > > > > - Please use macro here: > > > > %{_includedir}/%{basen}/*.h > > > > - Please use librinutils as base package and add a -devel subpackage and > > add a > > > > Provides: librinutils-static = %{version}-%{release} > > > > See > > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > > #_packaging_header_only_libraries > > Thanks! But for the life of me I cannot figure out how to make the main > package "BuildArch: noarch" and the -devel package "BuildArch: > "-plat-dependent. rpmlint warns on both cases where both are the same. Figured it out by looking at the cereal package (dnf info FTW). Anyway: https://www.shlomifish.org/Files/files/arcs/librinutils-0.1.4-1.fc32.src.rpm and https://www.shlomifish.org/Files/files/code/librinutils.spec . Thanks! - Just use: %package devel - Why did you make the headers noarch? The link I sent you explicitly says the opposite: Do not use noarch It may be tempting to make the header library package noarch, since the header files themselves are simply text. However, a library should have tests which should be run on all architectures. Also, the install process may modify the installed headers depending on the build architecture. For these reasons, header-only packages must not be marked noarch. - Also why not name it rinutils instead of librinutils? Using lib- prefix is a Debianesque way of doing. (In reply to Robert-André Mauchin from comment #4) > - Just use: > > %package devel > > - Why did you make the headers noarch? The link I sent you explicitly says > the opposite: > > Do not use noarch > > It may be tempting to make the header library package noarch, since the > header files themselves are simply text. However, a library should have > tests which should be run on all architectures. Also, the install process > may modify the installed headers depending on the build architecture. For > these reasons, header-only packages must not be marked noarch. > > > - Also why not name it rinutils instead of librinutils? Using lib- prefix > is a Debianesque way of doing. Fixed here: * https://www.shlomifish.org/Files/files/code/rinutils.spec * https://www.shlomifish.org/Files/files/arcs/rinutils-0.1.4-1.fc32.src.rpm Thanks! Provides: lib%{basen}-static = %{version}-%{release}
→
Provides: %{basen}-static = %{version}-%{release}
- Also you must install the LICERSE file with %license in %ifiles:
%license LICENSE
(In reply to Shlomi Fish from comment #5) > (In reply to Robert-André Mauchin from comment #4) > > - Just use: > > > > %package devel > > > > - Why did you make the headers noarch? The link I sent you explicitly says > > the opposite: > > > > Do not use noarch > > > > It may be tempting to make the header library package noarch, since the > > header files themselves are simply text. However, a library should have > > tests which should be run on all architectures. Also, the install process > > may modify the installed headers depending on the build architecture. For > > these reasons, header-only packages must not be marked noarch. > > > > > > - Also why not name it rinutils instead of librinutils? Using lib- prefix > > is a Debianesque way of doing. > > Fixed here: > Thanks Robert! Should be fixed here (same place): > * https://www.shlomifish.org/Files/files/code/rinutils.spec > > * https://www.shlomifish.org/Files/files/arcs/rinutils-0.1.4-1.fc32.src.rpm > > Thanks! Package approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rinutils Please close your Review Requests when they are complete. |