Bug 1780894

Summary: conmon-2.0.3-2.giteb5fa88.el8 contains broken read statement: if (read(fd, &events, sizeof(events) < 0)) {
Product: Red Hat Enterprise Linux 8 Reporter: Jindrich Novy <jnovy>
Component: conmonAssignee: Jindrich Novy <jnovy>
Status: CLOSED CURRENTRELEASE QA Contact: David Darrah/Red Hat QE <ddarrah>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.2CC: dperpeet, gscrivan
Target Milestone: rc   
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: conmon-2.0.4-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-13 09:16:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1758101    
Bug Blocks:    

Description Jindrich Novy 2019-12-08 10:12:56 UTC
Description of problem:
https://cov01.lab.eng.brq.redhat.com/covscanhub/waiving/41352/142977/#defects

if (read(fd, &events, sizeof(events) < 0)) {

This is fixed by: https://github.com/containers/conmon/commit/df8c6aa516b22ca8fd28903024a90d9093d383e5

Comment 1 Jindrich Novy 2019-12-09 08:18:15 UTC
Is is ok to apply https://github.com/containers/conmon/commit/df8c6aa516b22ca8fd28903024a90d9093d383e5 over the conmon-2.0.3-2.giteb5fa88.el8 codebase?

Comment 2 Giuseppe Scrivano 2019-12-13 07:41:19 UTC
yes, that is fine