Bug 1781471
| Summary: | systemtap tapscrip probes that use stack trace functionality fail to compile | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Craig Ringer <craig> |
| Component: | systemtap | Assignee: | Frank Ch. Eigler <fche> |
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 31 | CC: | amerey, brolley, dsmith, fche, lberk, mjw, plambri, scox, serhei, wcohen |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-24 16:11:56 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Opened new upstream issue as https://sourceware.org/bugzilla/show_bug.cgi?id=25265 I've supplied a patch upstream for one issue. I also found a second one https://sourceware.org/bugzilla/show_bug.cgi?id=25267 that arises from a similar cause. This message is a reminder that Fedora 31 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '31'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 31 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |
On Fedora 31 with the stock systemtap-4.2-1.fc31.x86_64 (stap 4.2/0.177) and kernel-5.3.14-300.fc31.x86_64 probes that attempt to use the bundled tapset functions `ustack`, `ubacktrace`, `print_ubacktrace` etc will fail to compile with: ``` [craig@linux pglogical3-master]$ sudo stap -v dev-tools/stap/backtrace_anywhere.stp $HOME/pg/pg11/ 'unrecognized conflict resolver' Pass 1: parsed user script and 490 library scripts using 391688virt/165032res/9628shr/155604data kb, in 410usr/40sys/459real ms. Pass 2: analyzed script: 2 probes, 7 functions, 1 embed, 0 globals using 407908virt/182836res/10772shr/171824data kb, in 160usr/20sys/217real ms. Pass 3: translated to C into "/tmp/stapFp0X4O/stap_36181c9d60f549fc3d570f1980a16330_4085_src.c" using 407908virt/182968res/10900shr/171824data kb, in 100usr/290sys/562real ms. In file included from /tmp/stapFp0X4O/stap_36181c9d60f549fc3d570f1980a16330_4085_src.c:159: /usr/share/systemtap/runtime/stack.c:66:14: error: ‘struct stack_trace’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] 66 | struct stack_trace *trace); | ^~~~~~~~~~~ /usr/share/systemtap/runtime/stack.c: In function ‘_stp_stack_print_fallback’: /usr/share/systemtap/runtime/stack.c:202:21: error: storage size of ‘trace’ isn’t known 202 | struct stack_trace trace; | ^~~~~ In file included from ./include/asm-generic/bug.h:5, from ./arch/x86/include/asm/bug.h:83, from ./include/linux/bug.h:5, from ./include/linux/mmdebug.h:5, from ./include/linux/gfp.h:5, from /usr/share/systemtap/runtime/linux/runtime_defines.h:20, from /usr/share/systemtap/runtime/runtime_defines.h:8, from /tmp/stapFp0X4O/stap_36181c9d60f549fc3d570f1980a16330_4085_src.c:11: /usr/share/systemtap/runtime/unwind/unwind.h: In function ‘read_ptr_sect’: ./include/linux/compiler.h:328:5: error: this statement may fall through [-Werror=implicit-fallthrough=] 328 | do { \ | ^ ./include/linux/compiler.h:338:2: note: in expansion of macro ‘__compiletime_assert’ 338 | __compiletime_assert(condition, msg, prefix, suffix) | ^~~~~~~~~~~~~~~~~~~~ ./include/linux/compiler.h:350:2: note: in expansion of macro ‘_compiletime_assert’ 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) | ^~~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^~~~~~~~~~~~~~~~ /usr/share/systemtap/runtime/unwind/unwind.h:159:3: note: in expansion of macro ‘BUILD_BUG_ON’ 159 | BUILD_BUG_ON(sizeof(u64) != sizeof(value)); | ^~~~~~~~~~~~ In file included from /usr/share/systemtap/runtime/unwind.c:16, from /usr/share/systemtap/runtime/linux/runtime.h:255, from /usr/share/systemtap/runtime/runtime.h:26, from /tmp/stapFp0X4O/stap_36181c9d60f549fc3d570f1980a16330_4085_src.c:27: /usr/share/systemtap/runtime/unwind/unwind.h:164:2: note: here 164 | case DW_EH_PE_absptr: | ^~~~ cc1: all warnings being treated as errors ``` e.g. ``` sudo stap -v -e 'probe process("/lib64/libc.so.6").function("fsync") { print_ubacktrace(); }' ``` See also https://sourceware.org/bugzilla/show_bug.cgi?id=24923