Bug 1781968 (CVE-2019-1354)

Summary: CVE-2019-1354 git: Git does not refuse to write out tracked files with backlashes in filenames
Product: [Other] Security Response Reporter: Pedro Sampaio <psampaio>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED NOTABUG QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: amahdal, besser82, c.david86, chrisw, hhorak, jorton, opohorel, pcahyna, pstodulk, sebastian.kisela, tmz
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: git 2.24.1, git 2.23.1, git 2.22.2, git 2.21.1, git 2.20.2, git 2.19.3, git 2.18.2, git 2.17.3, git 2.16.6, git 2.15.4, git 2.14.6 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-17 18:10:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1781969    
Bug Blocks: 1781145    

Description Pedro Sampaio 2019-12-11 00:30:52 UTC 
Filenames on Linux/Unix can contain backslashes. On Windows, backslashes are directory separators. Git did not use to refuse to write out tracked files with such filenames.

References:

https://kernel.googlesource.com/pub/scm/git/git/+/refs/tags/v2.24.1/Documentation/RelNotes/2.14.6.txt
Comment 1 Pedro Sampaio 2019-12-11 00:31:25 UTC 
Created git tracking bugs for this issue:

Affects: fedora-all [bug 1781969]
Comment 2 Pavel Cahyna 2019-12-12 09:24:15 UTC 
Does this bug apply to Fedora (or RHEL)? The commit (https://git.kernel.org/pub/scm/git/git.git/commit/?id=e1d911dd4c7b76a5a8cec0f5c8de15981e34da83) explicitly mentions mingw.
Comment 3 Riccardo Schirone 2019-12-13 16:41:55 UTC 
oss-security mailing list reference:
https://www.openwall.com/lists/oss-security/2019/12/13/1
Comment 4 Riccardo Schirone 2019-12-13 16:43:05 UTC 
External References:

https://github.com/git/git/security/advisories/GHSA-xjx4-8694-q2fq
Comment 5 Riccardo Schirone 2019-12-17 18:09:41 UTC 
Upstream patch:
https://github.com/git/git/commit/e1d911dd4c7b76a5a8cec0f5c8de15981e34da83
Comment 6 Riccardo Schirone 2019-12-17 18:10:23 UTC 
Statement:

This issue did not affect the versions of git as shipped with Red Hat Enterprise Linux 6, 7, and 8 as this is a Windows only issue and it does not affect the Linux versions of git.