Bug 1782467

Note, the following are not installed as part of ocp 4.x:
* devtoolset-7-perftools
* devtoolset-7-toolchain

Next, that are no upstream changes for deprecating mysql-57 nor redis-32.  Those will not be part of this bugzilla change.

Also note, while SCL updated their template to reference version 5, they failed to update the imagestream to include version 5 ... see https://raw.githubusercontent.com/sclorg/redis-container/master/imagestreams/redis-rhel7.json
and 
https://raw.githubusercontent.com/sclorg/redis-container/master/examples/redis-ephemeral-template.json


their persistent template still points to 3.2

this will be exluded with this bug changes as well

@Siamak - can you loop back with the SCL folks who asked you about these deprecations and get them to fix it?

Turns out SCL's cakephp templates still reference PHP 7.1

So we cannot accept those deprecations until the templates at https://github.com/sclorg/cakephp-ex/tree/master/openshift/templates are changed to reference 7.2

Siamak has initiated an email thread with the SCL folks.

Add two comments in https://github.com/openshift/cluster-samples-operator/pull/209 , and php:7.0, php:7.1,nodejs:8 istags aren't removed.
Also redis imagestream only have 3.2,latest tag.

$ oc get  is php -n openshift  -o yaml 
apiVersion: image.openshift.io/v1
kind: ImageStream
metadata:
  annotations:
    openshift.io/display-name: PHP
    openshift.io/image.dockerRepositoryCheck: "2019-12-22T23:39:33Z"
    samples.operator.openshift.io/version: 4.4.0-0.nightly-2019-12-20-210709
  creationTimestamp: "2019-12-22T23:35:43Z"
  generation: 2
  labels:
    samples.operator.openshift.io/managed: "true"
  name: php
  namespace: openshift
  resourceVersion: "15485"
  selfLink: /apis/image.openshift.io/v1/namespaces/openshift/imagestreams/php
  uid: 04b0add9-f560-4a95-8817-74911fae1099
spec:
  lookupPolicy:
    local: false
  tags:
  - annotations:
      description: Build and run PHP 7.0 applications on RHEL 7. For more information
        about using this builder image, including OpenShift considerations, see https://github.com/sclorg/s2i-php-container/blob/master/7.0/README.md.
      iconClass: icon-php
      openshift.io/display-name: PHP 7.0
      openshift.io/provider-display-name: Red Hat, Inc.
      sampleRepo: https://github.com/sclorg/cakephp-ex.git
      supports: php:7.0,php
      tags: builder,php
      version: "7.0"
    from:
      kind: DockerImage
      name: registry.redhat.io/rhscl/php-70-rhel7:latest
    generation: 2
    importPolicy: {}
    name: "7.0"
    referencePolicy:
      type: Local
  - annotations:
      description: Build and run PHP 7.1 applications on RHEL 7. For more information
        about using this builder image, including OpenShift considerations, see https://github.com/sclorg/s2i-php-container/blob/master/7.1/README.md.
      iconClass: icon-php
      openshift.io/display-name: PHP 7.1
      openshift.io/provider-display-name: Red Hat, Inc.
      sampleRepo: https://github.com/sclorg/cakephp-ex.git
      supports: php:7.1,php
      tags: builder,php
      version: "7.1"
    from:
      kind: DockerImage
      name: registry.redhat.io/rhscl/php-71-rhel7:latest
    generation: 2
    importPolicy: {}
    name: "7.1"
    referencePolicy:
      type: Local
  - annotations:
      description: Build and run PHP 7.2 applications on RHEL 7. For more information
        about using this builder image, including OpenShift considerations, see https://github.com/sclorg/s2i-php-container/blob/master/7.2/README.md.
      iconClass: icon-php
      openshift.io/display-name: PHP 7.2
      openshift.io/provider-display-name: Red Hat, Inc.
      sampleRepo: https://github.com/sclorg/cakephp-ex.git
      supports: php:7.2,php
      tags: builder,php
      version: "7.2"
    from:
      kind: DockerImage
      name: registry.redhat.io/rhscl/php-72-rhel7:latest
    generation: 2
    importPolicy: {}
    name: "7.2"
    referencePolicy:
      type: Local
  - annotations:
      description: |-
        Build and run PHP applications on RHEL 7. For more information about using this builder image, including OpenShift considerations, see https://github.com/sclorg/s2i-php-container/blob/master/7.2/README.md.

        WARNING: By selecting this tag, your application will automatically update to use the latest version of PHP available on OpenShift, including major version updates.
      iconClass: icon-php
      openshift.io/display-name: PHP (Latest)
      openshift.io/provider-display-name: Red Hat, Inc.
      sampleRepo: https://github.com/sclorg/cakephp-ex.git
      supports: php
      tags: builder,php
    from:
      kind: ImageStreamTag
      name: "7.2"
    generation: 1
    importPolicy: {}
    name: latest
    referencePolicy:
      type: Local
status:
  dockerImageRepository: image-registry.openshift-image-registry.svc:5000/openshift/php
  publicDockerImageRepository: default-route-openshift-image-registry.apps.qe-groupd-1223.qe.devcluster.openshift.com/openshift/php
  tags:
  - items:
    - created: "2019-12-22T23:39:33Z"
      dockerImageReference: registry.redhat.io/rhscl/php-70-rhel7@sha256:5fe71824f8cd33e087a8345dae0d50d246d3032b179ccfbc21a2d2aaea24e2dc
      generation: 2
      image: sha256:5fe71824f8cd33e087a8345dae0d50d246d3032b179ccfbc21a2d2aaea24e2dc
    tag: "7.0"
  - items:
    - created: "2019-12-22T23:39:33Z"
      dockerImageReference: registry.redhat.io/rhscl/php-71-rhel7@sha256:289ef5852151a1a3ea4fdf2581a86a60ada0719e54a5ddd78f5252742e6d2b8d
      generation: 2
      image: sha256:289ef5852151a1a3ea4fdf2581a86a60ada0719e54a5ddd78f5252742e6d2b8d
    tag: "7.1"
  - items:
    - created: "2019-12-22T23:39:33Z"
      dockerImageReference: registry.redhat.io/rhscl/php-72-rhel7@sha256:763651a0418598074ecb76ba0d2f03affc1bf2680d2a05e2aef185b51c3471dd
      generation: 2
      image: sha256:763651a0418598074ecb76ba0d2f03affc1bf2680d2a05e2aef185b51c3471dd
    tag: "7.2"
  - items:
    - created: "2019-12-22T23:39:33Z"
      dockerImageReference: registry.redhat.io/rhscl/php-72-rhel7@sha256:763651a0418598074ecb76ba0d2f03affc1bf2680d2a05e2aef185b51c3471dd
      generation: 2
      image: sha256:763651a0418598074ecb76ba0d2f03affc1bf2680d2a05e2aef185b51c3471dd
    tag: latest

$oc get is  nodejs  -n openshift 
NAME     IMAGE REPOSITORY                                                                                          TAGS                         UPDATED
nodejs   default-route-openshift-image-registry.apps.qe-groupd-1223.qe.devcluster.openshift.com/openshift/nodejs   10,10-SCL,8,8-RHOAR,latest   4 hours ago

oc get is  redis  -n openshift 
NAME    IMAGE REPOSITORY                                                                                         TAGS         UPDATED
redis   default-route-openshift-image-registry.apps.qe-groupd-1223.qe.devcluster.openshift.com/openshift/redis   3.2,latest   4 hours ago

See https://bugzilla.redhat.com/show_bug.cgi?id=1782467#c3 for why php was not updated .... that was expected 

See https://bugzilla.redhat.com/show_bug.cgi?id=1782467#c2 and https://bugzilla.redhat.com/show_bug.cgi?id=1782467#c1 for why redis was not updated .... that was expected 

nodejs 8 is odd .... I know see some discrepancies between 

https://github.com/openshift/library/blob/master/official.yaml

and 

https://github.com/sclorg/s2i-nodejs-container/pull/222/files

I will need to loop back with sclorg.

Have https://github.com/openshift/library/pull/199 up to help sclorg fix this.

Assuming they agree and we merge that PR, we'll then need to update samples operator with the new openshift/library contents and see if e2e's pass.

nodejs changes are now in https://github.com/openshift/cluster-samples-operator/pull/213

OK the PHP stuff finally merged, but the nodejs stuff is still pending.

Gabe, see these below comments about nginx, need fix them too.
https://github.com/openshift/cluster-samples-operator/pull/209/files#r360751595 
https://github.com/openshift/cluster-samples-operator/pull/209/files#r360751595

@XiuJuan I've emailed SCL and included you to ask why they removed nginx 1.12 but left 1.10

@XiuJuan - per email exchanges with SCL, removing nginx 12 but leaving 10 is intentional, given the atypical support lifecycles for them.

@Gabe
Thank you,I found the details explain about removal nginx 12 in the email.

But there is still minor issue,
In https://github.com/sclorg/nginx-container/blob/master/imagestreams/nginx-rhel7.json#L16 , when it's a defination of nginx:1.14 tag, but display-name is 1.10
also in https://github.com/sclorg/nginx-container/blob/master/imagestreams/nginx-rhel7.json#L36 ,it's a defination of nginx:1.10 tag but point to 1.14

Verified comment #21 with 4.4.0-0.nightly-2020-01-17-003449 payload.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581