Bug 1782588

Summary: GCP destroy is leaking Project IAM bindings.
Product: OpenShift Container Platform Reporter: Abhinav Dahiya <adahiya>
Component: InstallerAssignee: Abhinav Dahiya <adahiya>
Installer sub component: openshift-installer QA Contact: Yang Yang <yanyang>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: jialiu
Version: 4.2.0   
Target Milestone: ---   
Target Release: 4.2.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1782584 Environment:
Last Closed: 2020-01-07 17:55:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1782583, 1782584    
Bug Blocks:    

Description Abhinav Dahiya 2019-12-11 22:00:46 UTC 
+++ This bug was initially created as a clone of Bug #1782584 +++

+++ This bug was initially created as a clone of Bug #1782583 +++

Description of problem:
Based on https://cloud.google.com/resource-manager/reference/rest/Shared.Types/Binding

The members values can be:
```
deleted:serviceAccount:{emailid}?uid={uniqueid}: An email address (plus unique identifier) representing a service account that has been recently deleted. For example, my-other-app.com?uid=123456789012345678901. If the service account is undeleted, this value reverts to serviceAccount:{emailid} and the undeleted service account retains the role in the binding.
```

this looks like a new addition to the API since the archive from Oct 26, 2019 doesn't have these value type. see https://web.archive.org/web/20181026092140/https://cloud.google.com/resource-manager/reference/rest/Shared.Types/Binding

Also it doesn't look like the API is being consistent with the result as two consecutive requests are returning different responses :P
```
[7:08:11] ➜  installer git:(add_platform_owners) ✗ gcloud projects get-iam-policy openshift-gce-devel-ci --format json | grep "ci-op-4wlm9"

        "serviceAccount:ci-op-4wlm9-m.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-openshift-m-w75nq.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-m.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-m.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-w.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-openshift-i-nnvgl.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-m.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-openshift-i-zh522.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-openshift-m-w75nq.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-m.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-openshift-i-zh522.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-w.gserviceaccount.com",

[7:08:23] ➜  installer git:(add_platform_owners) ✗ gcloud projects get-iam-policy openshift-gce-devel-ci --format json | grep "ci-op-4wlm9"

        "deleted:serviceAccount:ci-op-4wlm9-m.gserviceaccount.com?uid=111636284758116941377",

        "deleted:serviceAccount:ci-op-4wlm9-openshift-m-w75nq.gserviceaccount.com?uid=115542993089051207368",

        "deleted:serviceAccount:ci-op-4wlm9-m.gserviceaccount.com?uid=111636284758116941377",

        "deleted:serviceAccount:ci-op-4wlm9-m.gserviceaccount.com?uid=111636284758116941377",

        "deleted:serviceAccount:ci-op-4wlm9-w.gserviceaccount.com?uid=106651455962694555805",

        "deleted:serviceAccount:ci-op-4wlm9-openshift-i-nnvgl.gserviceaccount.com?uid=113695655870612204124",

        "deleted:serviceAccount:ci-op-4wlm9-m.gserviceaccount.com?uid=111636284758116941377",

        "deleted:serviceAccount:ci-op-4wlm9-openshift-i-zh522.gserviceaccount.com?uid=103715387178859573892",

        "deleted:serviceAccount:ci-op-4wlm9-openshift-m-w75nq.gserviceaccount.com?uid=115542993089051207368",

        "deleted:serviceAccount:ci-op-4wlm9-m.gserviceaccount.com?uid=111636284758116941377",

        "deleted:serviceAccount:ci-op-4wlm9-openshift-i-zh522.gserviceaccount.com?uid=103715387178859573892",

        "deleted:serviceAccount:ci-op-4wlm9-w.gserviceaccount.com?uid=106651455962694555805",
```


The installer destroy skips over these `deleted:` prefixed bindings.
Comment 2 Yang Yang 2019-12-25 07:00:12 UTC 
Verify it with payload 4.2.0-0.nightly-2019-12-23-132554.

Steps of verification as below:

1. Get the service accounts after the cluster setup
# gcloud projects get-iam-policy openshift-qe --format json | grep "yy42ip"
        "serviceAccount:yy42ip-nwh8z-m.gserviceaccount.com",
        "serviceAccount:yy42ip-nwh8z-openshift-m-nnbg6.gserviceaccount.com",
        "serviceAccount:yy42ip-nwh8z-m.gserviceaccount.com",
        "serviceAccount:yy42ip-nwh8z-m.gserviceaccount.com",
        "serviceAccount:yy42ip-nwh8z-w.gserviceaccount.com",
        "serviceAccount:yy42ip-nwh8z-openshift-i-hzbjf.gserviceaccount.com",
        "serviceAccount:yy42ip-nwh8z-m.gserviceaccount.com",
        "serviceAccount:yy42ip-nwh8z-openshift-i-8d95j.gserviceaccount.com",
        "serviceAccount:yy42ip-nwh8z-openshift-m-nnbg6.gserviceaccount.com",
        "serviceAccount:yy42ip-nwh8z-m.gserviceaccount.com",
        "serviceAccount:yy42ip-nwh8z-openshift-i-8d95j.gserviceaccount.com",
        "serviceAccount:yy42ip-nwh8z-w.gserviceaccount.com",

2. Get the service accounts after the cluster is destroyed

# gcloud projects get-iam-policy openshift-qe --format json | grep "yy42ip"
No output
Comment 4 errata-xmlrpc 2020-01-07 17:55:11 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0014