Bug 178295
| Summary: | [calendar] unable to remove pre-edit buffer cleanly in day view | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lawrence Lim <llim> | ||||||||||
| Component: | evolution | Assignee: | Matthew Barnes <mbarnes> | ||||||||||
| Status: | CLOSED UPSTREAM | QA Contact: | |||||||||||
| Severity: | medium | Docs Contact: | |||||||||||
| Priority: | low | ||||||||||||
| Version: | 6 | CC: | eng-i18n-bugs, majain, mattdm, mbarnes, tools-bugs | ||||||||||
| Target Milestone: | --- | Keywords: | i18n | ||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2007-11-08 03:19:48 UTC | Type: | --- | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Bug Depends On: | |||||||||||||
| Bug Blocks: | 208799 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Lawrence Lim
2006-01-19 07:22:13 UTC
Created attachment 126383 [details]
screenshot
Hi llim,
You've mentioned that
1.in any of the CJKI locale, start evolution-> calendar (eg ja_JP.UTF-8)
2.use the default day view
3.select 2PM, enter a
4.activate SCIM using Ctrl-SPACE
When I enter "a", I cannot activate the scim IM as there's no choice. Is the
default day view the same i'm using in the screenshot?
Note that I can activate scim IM in evo mail (html mode).
Hi llim, When you say "Select 2 pm", you mean mean to single click on 2 pm or double click? - If single click, then scim cannot be activated as there's no option in right click to choose the IM (as in screenshot). - If you are talking of double click, which text box are you refering? Thanks. RE Comment #1 Yes, in the screenshot, tt's the day view. RE Comment #2 Its a single click (notice the time slot gets focus and is hightlighted) -> enter a (allow u to start IC, u will see blinking cursor) -> Ctrl-SPACE Fedora Core 3 is now maintained by the Fedora Legacy project for security updates only. If this problem is a security issue, please reopen and reassign to the Fedora Legacy product. If it is not a security issue and hasn't been resolved in the current FC5 updates or in the FC6 test release, reopen and change the version to match. Thank you! Hi Matthew, I dont think this is a security issue. & this behaviour is still observed in rawhide. Hence changing version from fc3t2 to devel. Also, changing component to Evolution. Thanks, Mayank As Mayank is working on this bug, reassigning it to him until he have completed. Mayank, please report on your current status. If i'm not wrong, when preedit is being deleted & the stage is reached when last char is left in preedit buffer & backspace is hit, text->preedit_len becomes zero (expected behaviour) but e_text_draw still draws it. If somehow it can be called again, i think it will cleanly remove the string. calling reset_layout(EText) in e_text_draw does the thing. Created attachment 132979 [details]
patch for solution of the problem
The patch with some code reorganization & comments & fix for this bug.
Filled bug upstream at http://bugzilla.gnome.org/show_bug.cgi?id=348638 Matthew, can you please test the patch? Me? Oh No, it was for mbarnes :) Okay, good, 'cause I have *no idea*. I'm just visiting this bug. :) Mayank, some of the logic has changed slightly in 2.7.90 so the patch does not apply cleanly. The changes are probably not relevant to this bug, but can you please double check? evolution-2.7.90-1 should be in Rawhide tomorrow. Created attachment 133068 [details]
rediffed patch
Okay, i diffed it again against the CVS head.
CVS head as in upstream cvs. (In reply to comment #15) > evolution-2.7.90-1 should be in Rawhide tomorrow. I take that back. Evolution-Data-Server 1.7.90 changed a bunch of sonames, so I need to rebuild some things before this patch gets into Rawhide. Oh... Mattew, i tell you, these version changes caused me so much trouble... the builds were going perfect but my calendar was being rendered uneditable... version mismatch between eds & evo! The helpfull evo team at #evolution was there to help :) Be carefull with the eds versions while building newer evo packages. Whoops, sorry for spelling your name incorrectly. reviewed a patch. basically it looks good though, does the last chunk that contains gtk_im_context_focus_in/out() really need to be called to fix this bug? Oops, I think that modifications were from a previous bug I was working on. I'll remove that hunk & reupload the patch. Thanks Tagoh san. Created attachment 133215 [details]
Modified patch
Modified patch with unrequired hunk removed.
Tagoh san, there is one more patch in upstream bug. Kindly have a look. Thanks. Mayank, Let me know when you have a patch ready for Rawhide. I'm backing off of E-D-S 1.7.90 and sticking with 1.7.4 for now. The upgrade breaks API/ABI stability and was causing people grief (sounds like you're aware of the pain). Matthew, We have 2 patches available upstream, one by me & another by an upstream developer. Since both of the patches are working fine, i've requested him to select the best one as he is more experienced evo contributor than I am... also, we want the best for evo :) I'm waiting for his response, i'll notify you once its decided upstream. Pinged Srag on #evo (irc.gimp.org) & asked him to get the patches reviewed & approved. User majain's account has been closed Moving this to the upstream bug. I have an updated patch there waiting for review. If someone could kindly apply the patch and verify that it works I can go ahead and commit it. I can assist with build issues if needed. http://bugzilla.gnome.org/show_bug.cgi?id=348638 |