Bug 1783017

Summary:	Review Request: rust-i3status-rs - Feature-rich and resource-friendly replacement for i3status, written in Rust
Product:	[Fedora] Fedora	Reporter:	Artem <ego.cordatus>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-12-16 15:41:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1783704
Bug Blocks:

Description Artem 2019-12-12 19:54:24 UTC

Spec URL: https://atim.fedorapeople.org/for-review/rust-i3status-rs.spec
SRPM URL: https://atim.fedorapeople.org/for-review/rust-i3status-rs-0.12.0-1.fc32.src.rpm

Description:
i3status-rs is a feature-rich and resource-friendly replacement for i3status,
written in pure Rust. It provides a way to display "blocks" of system
information (time, battery status, volume, etc) on the i3 bar. It is also
compatible with sway.

Fedora Account System Username: atim

Comment 1 Robert-André Mauchin 🐧 2019-12-14 17:14:10 UTC

uuid bump doesn't work, either you work with upstream to make it work, see https://uuid-rs.groups.io/g/main/message/6, or you make a compat package rust-uuid0.6

Comment 2 Robert-André Mauchin 🐧 2019-12-14 17:15:55 UTC

Seems they are not keen on updating things https://github.com/greshake/i3status-rust/issues/272

Comment 3 Robert-André Mauchin 🐧 2019-12-14 17:33:20 UTC

# rust-uuid0.6.spec
# Generated by rust2rpm 12
%bcond_without check
%global debug_package %{nil}

%global crate uuid

Name:           rust-%{crate}0.6
Version:        0.6.5
Release:        1%{?dist}
Summary:        Library to generate and parse UUIDs

# Upstream license specification: Apache-2.0 OR MIT
License:        ASL 2.0 or MIT
URL:            https://crates.io/crates/uuid
Source:         %{crates_source}

ExclusiveArch:  %{rust_arches}
%if %{__cargo_skip_build}
BuildArch:      noarch
%endif

BuildRequires:  rust-packaging

%global _description %{expand:
Library to generate and parse UUIDs.}

%description %{_description}

%package        devel
Summary:        %{summary}
BuildArch:      noarch

%description    devel %{_description}

This package contains library source intended for building other packages
which use "%{crate}" crate.

%files          devel
%license LICENSE-MIT LICENSE-APACHE
%doc README.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/

%package     -n %{name}+default-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+default-devel %{_description}

This package contains library source intended for building other packages
which use "default" feature of "%{crate}" crate.

%files       -n %{name}+default-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+byteorder-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+byteorder-devel %{_description}

This package contains library source intended for building other packages
which use "byteorder" feature of "%{crate}" crate.

%files       -n %{name}+byteorder-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+const_fn-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+const_fn-devel %{_description}

This package contains library source intended for building other packages
which use "const_fn" feature of "%{crate}" crate.

%files       -n %{name}+const_fn-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+md5-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+md5-devel %{_description}

This package contains library source intended for building other packages
which use "md5" feature of "%{crate}" crate.

%files       -n %{name}+md5-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+nightly-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+nightly-devel %{_description}

This package contains library source intended for building other packages
which use "nightly" feature of "%{crate}" crate.

%files       -n %{name}+nightly-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+rand-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+rand-devel %{_description}

This package contains library source intended for building other packages
which use "rand" feature of "%{crate}" crate.

%files       -n %{name}+rand-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+serde-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+serde-devel %{_description}

This package contains library source intended for building other packages
which use "serde" feature of "%{crate}" crate.

%files       -n %{name}+serde-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+sha1-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+sha1-devel %{_description}

This package contains library source intended for building other packages
which use "sha1" feature of "%{crate}" crate.

%files       -n %{name}+sha1-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+slog-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+slog-devel %{_description}

This package contains library source intended for building other packages
which use "slog" feature of "%{crate}" crate.

%files       -n %{name}+slog-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+std-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+std-devel %{_description}

This package contains library source intended for building other packages
which use "std" feature of "%{crate}" crate.

%files       -n %{name}+std-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+u128-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+u128-devel %{_description}

This package contains library source intended for building other packages
which use "u128" feature of "%{crate}" crate.

%files       -n %{name}+u128-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+use_std-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+use_std-devel %{_description}

This package contains library source intended for building other packages
which use "use_std" feature of "%{crate}" crate.

%files       -n %{name}+use_std-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+v1-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+v1-devel %{_description}

This package contains library source intended for building other packages
which use "v1" feature of "%{crate}" crate.

%files       -n %{name}+v1-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+v3-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+v3-devel %{_description}

This package contains library source intended for building other packages
which use "v3" feature of "%{crate}" crate.

%files       -n %{name}+v3-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+v4-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+v4-devel %{_description}

This package contains library source intended for building other packages
which use "v4" feature of "%{crate}" crate.

%files       -n %{name}+v4-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%package     -n %{name}+v5-devel
Summary:        %{summary}
BuildArch:      noarch

%description -n %{name}+v5-devel %{_description}

This package contains library source intended for building other packages
which use "v5" feature of "%{crate}" crate.

%files       -n %{name}+v5-devel
%ghost %{cargo_registry}/%{crate}-%{version_no_tilde}/Cargo.toml

%prep
%autosetup -n %{crate}-%{version_no_tilde} -p1
%cargo_prep

%generate_buildrequires
%cargo_generate_buildrequires

%build
%cargo_build

%install
%cargo_install

%if %{with check}
%check
%cargo_test
%endif

%changelog

Comment 4 Artem 2019-12-14 19:09:05 UTC

With compat uuid version compiles fun. Updated spec:

https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01129292-rust-i3status-rs/rust-i3status-rs.spec

https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01129292-rust-i3status-rs/rust-i3status-rs-0.12.0-2.fc32.src.rpm

Comment 5 Robert-André Mauchin 🐧 2019-12-14 20:38:28 UTC

 - Why 0655? No need for executable perms here, just go with 0644

install -m 0644 -Dp example_config.toml %{buildroot}%{_sysconfdir}/xdg/i3/status.toml


Package approved otherwise, please fix this issue before import.


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Comment 6 Gwyn Ciesla 2019-12-16 14:39:47 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-i3status-rs