Bug 1783069

Summary:	rust-libgit2-sys-0.10.0 is available
Product:	[Fedora] Fedora	Reporter:	Upstream Release Monitoring <upstream-release-monitoring>
Component:	rust-libgit2-sys	Assignee:	Igor Raits <igor.raits>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	igor.raits, jistone, rust-sig
Target Milestone:	---	Keywords:	FutureFeature, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-12-26 06:08:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Upstream Release Monitoring 2019-12-12 23:22:04 UTC

Latest upstream release: 0.10.0
Current version/release in rawhide: 0.9.1-1.fc32
URL: https://crates.io/crates/libgit2-sys

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from anitya: https://release-monitoring.org/project/16572/

Comment 1 Josh Stone 2019-12-13 00:25:24 UTC

Beware, this is probably not compatible with our system libgit2.

https://github.com/rust-lang/git2-rs/pull/503
> This updates the libgit2 submodule to latest master.
>
> As several public struct members as well as some functions' parameters/return values have changed fundamental types (e.g from git_off_t which is an int64_t to git_object_size_t which is an uint64_t) I bumped the minor versions of both libgit2-sys and git2-rs (meaning it's equivalent to a major version bump for 0.x versions). As I'm not familiar with the version increment policy, let me know if that's wrong.

In particular, here's libgit2-sys/lib.rs that matters for FFI ABI:
https://github.com/rust-lang/git2-rs/pull/503/files#diff-bc9f5e23745614c633f0d03c71fe327c

The sign change from i64 to u64 shouldn't actually matter for system lib compatibility, as long as nothing was actually using negative values. The added fields in git_cert_hostkey and git_diff_file are more of a problem -- could cause out-of-bounds memory access if that doesn't match.