Bug 1783356

Summary: "Monthly Charges" section on CF Service UI -> dashboard should be RBAC
Product: Red Hat CloudForms Management Engine Reporter: Khushbu Borole <kborole>
Component: UI - ServiceAssignee: Martin Hradil <mhradil>
Status: CLOSED NOTABUG QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: unspecified    
Version: 5.11.0CC: bmidwood, dmetzger, lavenel, mfeifer, mshriver, obarenbo
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.12.0Flags: mfeifer: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1805806 (view as bug list) Environment:
Last Closed: 2020-06-10 13:10:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1805806    
Attachments:
Description Flags
RBAC - ServiceUI -> Dashboard -> Monthly_charge_view none

Description Khushbu Borole 2019-12-13 15:54:44 UTC
Created attachment 1644880 [details]
RBAC - ServiceUI -> Dashboard -> Monthly_charge_view

Description of problem:
"Monthly Charges" section on CF Service UI -> dashboard should be RBAC

Some customers `want to/don't want to` see the "Monthly Charges" section on that dashboard.

This section will be more useful if it becomes an optional section which can be possible using a RBAC

Version-Release number of selected component (if applicable):
Red Hat CloudForms 5.0

Actual results:
In Actual RBAC, ServiceUI -> Dashboard -> Monthly_charge_view is present but when ever I deselect the `Monthly_charge_view`, it eventually deselects the entire `Dashboard` menu.

Expected results:
deselecting the `Monthly_charge_view`should deselect only that option and not the entire Dashboard

Comment 3 Dave Johnson 2019-12-18 15:01:42 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 7 CFME Bot 2020-01-23 14:10:59 UTC
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/68e916b6dcf28c586dd55adcd3c3887e008b316f
commit 68e916b6dcf28c586dd55adcd3c3887e008b316f
Author:     Martin Hradil <mhradil>
AuthorDate: Wed Dec 18 11:15:40 2019 -0500
Commit:     Martin Hradil <mhradil>
CommitDate: Wed Dec 18 11:15:40 2019 -0500

    RBAC: Add sui_dashboard_show under sui_dashboard

    right now, the sui_dashboard feature has only 1 child ("monthly charge view"),
    making it impossible to actually hide the monthy charge view without also dropping the whole dashboard.
    (SUI is using the sui_dashboard parent to determine whether a dashboard should be visible now)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1783356

 db/fixtures/miq_product_features.yml | 4 +
 1 file changed, 4 insertions(+)

Comment 8 CFME Bot 2020-01-23 14:11:46 UTC
New commit detected on ManageIQ/manageiq-ui-service/master:

https://github.com/ManageIQ/manageiq-ui-self_service/commit/a2ca46235701af52484f3cde0c4c89ade07873bb
commit a2ca46235701af52484f3cde0c4c89ade07873bb
Author:     Martin Hradil <mhradil>
AuthorDate: Wed Dec 18 11:09:51 2019 -0500
Commit:     Martin Hradil <mhradil>
CommitDate: Wed Dec 18 11:09:51 2019 -0500

    SUI - use sui_dashboard_show instead of the sui_dashboard folder for VIEW dashboard permission

    this way, when the new "View Dashboard" feature is not set, there will be no Dashboard

    https://bugzilla.redhat.com/show_bug.cgi?id=1783356

 client/app/core/product-features.constants.json | 2 +-
 tests/mock/rbac/allPermissions.json | 7 +-
 2 files changed, 7 insertions(+), 2 deletions(-)