Bug 1783784

Summary:	Review Request: python-requests-download - Download files using requests and save them to a target path
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mail, package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-19 10:16:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miro Hrončok 2019-12-15 16:57:23 UTC

Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-requests-download.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-requests-download-0.1.2-1.fc31.src.rpm

Description:
A convenient function to download to a file using requests.

Basic usage:

    url = "https://github.com/takluyver/requests_download/archive/master.zip"
    download(url, "requests_download.zip")

An optional headers= parameter is passed through to requests.


Fedora Account System Username: churchyard

Comment 1 Zbigniew Jędrzejewski-Szmek 2019-12-15 18:17:22 UTC

Hmmm, could we maybe ask requests upstream to take this? Making a package for ~50 lines of python seems a bit overkill.

Comment 2 Miro Hrončok 2019-12-15 18:56:05 UTC

This is indeed a leftpad of Python. We could, but this is what flit uses and the maintainers of flit decided to make it a package. I suspect it will be a low effort package.

Comment 3 Zbigniew Jędrzejewski-Szmek 2019-12-15 20:19:51 UTC

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ "tests" pass
+ fedora-review is happy (except for one issue, see below)

rpmlint:
python3-requests-download.noarch: W: spelling-error %description -l en_US url -> URL, curl, purl

fedora-review:
- Package contains BR: python2-devel or python3-devel
→ this is provided by BuildRequires: pyproject-rpm-macros, so fedora-review is wrong here I think.

Package is APPROVED.

Comment 4 Miro Hrončok 2019-12-15 21:57:10 UTC

> fedora-review:
> - Package contains BR: python2-devel or python3-devel
> → this is provided by BuildRequires: pyproject-rpm-macros, so fedora-review is wrong here I think.

Correct. Thanks for the review.

Comment 5 Gwyn Ciesla 2019-12-16 14:29:18 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-requests-download