Bug 1783802

Summary:	Use C0 controls in notification patch instead of C1
Product:	[Fedora] Fedora	Reporter:	Egmont Koblinger <egmont>
Component:	vte291	Assignee:	Debarshi Ray <debarshir>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	31	CC:	alexander, debarshir, gnome-sig, klember
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	vte291-0.59.92-2.fc32 vte291-0.58.3-2.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-06 20:49:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Egmont Koblinger 2019-12-15 22:43:50 UTC

Hi Rishi,

The notification (preexec etc.) patch emits C1 controls (U+009D and U+009C).

A changelog entry in the patch says:

> Currently, using C0 controls to emit OSC 777 from PS0 (ie.,
> PS0=$(printf "\u009D777;preexec\u009C")) causes spurious characters to
> show up. C1 controls don't seem to suffer from this problem.

Do you have any more details? What spurious characters appear? In which terminal? Has that terminal been notified, is there any public bugreport, and has it addressed the problem?

Or could it be that the wrong number of backslashes were used, i.e. more escaping was applied that bash expected?

(Mind you, the changelog is worded incorrectly: it actually shows C1 where it says it shows C0.)

C1 is supported by fewer terminals, and using them here causes a problem in Alacritty (and presumably quite a few others) if it's launched from a VTE-based terminal: https://github.com/jwilm/alacritty/issues/3105.

Also I think I'd like to remove C1 support from VTE: https://gitlab.gnome.org/GNOME/vte/issues/209.

Could you please switch to C0 ("\]" and "\\")?

Comment 1 Debarshi Ray 2020-03-02 14:48:33 UTC

(In reply to Egmont Koblinger from comment #0)
> A changelog entry in the patch says:
> 
> > Currently, using C0 controls to emit OSC 777 from PS0 (ie.,
> > PS0=$(printf "\u009D777;preexec\u009C")) causes spurious characters to
> > show up. C1 controls don't seem to suffer from this problem.
> 
> Do you have any more details? What spurious characters appear? In which
> terminal? Has that terminal been notified, is there any public bugreport,
> and has it addressed the problem?

No, there's no public bug report. I recall that I made that observation back when the vte.sh script was oscillating a bit between C0 and C1 controls. So it might have been some transient bug.

Anyway, I checked again and I didn't see any problems with using C0 controls from PS0.

> Or could it be that the wrong number of backslashes were used, i.e. more
> escaping was applied that bash expected?

> (Mind you, the changelog is worded incorrectly: it actually shows C1 where
> it says it shows C0.)

Oops, yes, you are right. Thanks for pointing out the typo.

Comment 2 Debarshi Ray 2020-03-02 14:49:08 UTC

I have switched vte291 from Fedora 31 onwards to use C0 controls as suggested by Egmont.

Comment 3 Egmont Koblinger 2020-03-02 14:55:50 UTC

Thanks!

Just to clarify, I kinda made a typo here:

> Could you please switch to C0 ("\]" and "\\")?

The C0 version of OSC is Escape Closingbracket (0x1b 0x5d) to open and Escape Backslash (0x1b 0x5c) to close.

Comment 4 Debarshi Ray 2020-03-02 15:10:29 UTC

To be clear, I replaced this:
PS0=$(printf "\u009D777;preexec\u009C")

... with:
PS0=$(printf "\033]777;preexec\033\\")

Comment 5 Debarshi Ray 2020-03-02 15:22:34 UTC

Built vte291-0.58.3-2.fc31:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-146495d355

Comment 6 Fedora Update System 2020-03-02 19:57:06 UTC

vte291-0.58.3-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-146495d355

Comment 7 Fedora Update System 2020-03-03 17:33:54 UTC

adwaita-icon-theme-3.35.92-1.fc32, at-spi2-atk-2.34.2-1.fc32, at-spi2-core-2.35.92-1.fc32, clutter-1.26.2-11.fc32, eog-3.35.92-1.fc32, epiphany-3.35.92-1.fc32, file-roller-3.35.92-1.fc32, four-in-a-row-3.35.92-1.fc32, geary-3.35.90-1.fc32, glib-networking-2.63.92-1.fc32, glib2-2.64.0-1.fc32, gnome-boxes-3.35.91-1.fc32, gnome-calculator-3.35.92-1.fc32, gnome-calendar-3.35.92-1.fc32, gnome-control-center-3.35.92-1.fc32, gnome-getting-started-docs-3.35.92-1.fc32, gnome-initial-setup-3.35.92-1.fc32, gnome-mahjongg-3.35.92-1.fc32, gnome-maps-3.35.92-1.fc32, gnome-music-3.35.92-1.fc32, gnome-settings-daemon-3.35.92-1.fc32, gnome-shell-3.35.92-1.fc32, gnome-system-monitor-3.35.92-1.fc32, gnome-terminal-3.35.92-1.fc32, gnome-tetravex-3.35.92-1.fc32, gnome-user-docs-3.35.92-1.fc32, gvfs-1.43.92-1.fc32, libgdata-0.17.12-1.fc32, mutter-3.35.92-2.fc32, nautilus-3.35.92-1.fc32, polari-3.35.92-1.fc32, quadrapassel-3.35.92-1.fc32, simple-scan-3.35.92-1.fc32, vte291-0.59.92-2.fc32, wayland-protocols-1.20-1.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-405622043a

Comment 8 Fedora Update System 2020-03-04 20:14:08 UTC

adwaita-icon-theme-3.35.92-1.fc32, at-spi2-atk-2.34.2-1.fc32, at-spi2-core-2.35.92-1.fc32, clutter-1.26.2-11.fc32, eog-3.35.92-1.fc32, epiphany-3.35.92-1.fc32, file-roller-3.35.92-1.fc32, four-in-a-row-3.35.92-1.fc32, geary-3.35.90-1.fc32, glib-networking-2.63.92-1.fc32, glib2-2.64.0-1.fc32, gnome-boxes-3.35.91-1.fc32, gnome-calculator-3.35.92-1.fc32, gnome-calendar-3.35.92-1.fc32, gnome-color-manager-3.35.90-1.fc32, gnome-control-center-3.35.92-1.fc32, gnome-getting-started-docs-3.35.92-1.fc32, gnome-initial-setup-3.35.92-1.fc32, gnome-mahjongg-3.35.92-1.fc32, gnome-maps-3.35.92-1.fc32, gnome-multi-writer-3.35.90-1.fc32, gnome-music-3.35.92-1.fc32, gnome-settings-daemon-3.35.92-1.fc32, gnome-shell-3.35.92-1.fc32, gnome-software-3.35.92-1.fc32, gnome-system-monitor-3.35.92-1.fc32, gnome-terminal-3.35.92-1.fc32, gnome-tetravex-3.35.92-1.fc32, gnome-user-docs-3.35.92-1.fc32, gvfs-1.43.92-1.fc32, libgdata-0.17.12-1.fc32, mutter-3.35.92-2.fc32, nautilus-3.35.92-1.fc32, orca-3.35.92-1.fc32, polari-3.35.92-1.fc32, quadrapassel-3.35.92-1.fc32, simple-scan-3.35.92-1.fc32, vala-0.48.0-1.fc32, vte291-0.59.92-2.fc32, wayland-protocols-1.20-1.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-405622043a

Comment 9 Fedora Update System 2020-03-06 18:40:11 UTC

FEDORA-2020-405622043a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-405622043a

Comment 10 Fedora Update System 2020-03-06 20:23:08 UTC

adwaita-icon-theme-3.35.92-1.fc32, at-spi2-atk-2.34.2-1.fc32, at-spi2-core-2.35.92-1.fc32, clutter-1.26.2-11.fc32, eog-3.35.92-1.fc32, epiphany-3.35.92-1.fc32, file-roller-3.35.92-1.fc32, four-in-a-row-3.35.92-1.fc32, geary-3.35.90-1.fc32, glib-networking-2.63.92-1.fc32, glib2-2.64.0-1.fc32, gnome-boxes-3.35.91-1.fc32, gnome-calculator-3.35.92-1.fc32, gnome-calendar-3.35.92-1.fc32, gnome-color-manager-3.35.90-1.fc32, gnome-control-center-3.35.92-1.fc32, gnome-getting-started-docs-3.35.92-1.fc32, gnome-initial-setup-3.35.92-1.fc32, gnome-mahjongg-3.35.92-1.fc32, gnome-maps-3.35.92-1.fc32, gnome-multi-writer-3.35.90-1.fc32, gnome-music-3.35.92-1.fc32, gnome-settings-daemon-3.35.92-1.fc32, gnome-shell-3.35.92-1.fc32, gnome-software-3.35.92-1.fc32, gnome-system-monitor-3.35.92-1.fc32, gnome-terminal-3.35.92-1.fc32, gnome-tetravex-3.35.92-1.fc32, gnome-user-docs-3.35.92-1.fc32, gvfs-1.43.92-1.fc32, libgdata-0.17.12-1.fc32, mutter-3.35.92-3.fc32, nautilus-3.35.92-1.fc32, orca-3.35.92-1.fc32, polari-3.35.92-1.fc32, quadrapassel-3.35.92-1.fc32, simple-scan-3.35.92-1.fc32, vala-0.48.0-1.fc32, vte291-0.59.92-2.fc32, wayland-protocols-1.20-1.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-405622043a

Comment 11 Fedora Update System 2020-03-06 20:49:26 UTC

adwaita-icon-theme-3.35.92-1.fc32, at-spi2-atk-2.34.2-1.fc32, at-spi2-core-2.35.92-1.fc32, clutter-1.26.2-11.fc32, eog-3.35.92-1.fc32, epiphany-3.35.92-1.fc32, file-roller-3.35.92-1.fc32, four-in-a-row-3.35.92-1.fc32, geary-3.35.90-1.fc32, glib-networking-2.63.92-1.fc32, glib2-2.64.0-1.fc32, gnome-boxes-3.35.91-1.fc32, gnome-calculator-3.35.92-1.fc32, gnome-calendar-3.35.92-1.fc32, gnome-color-manager-3.35.90-1.fc32, gnome-control-center-3.35.92-1.fc32, gnome-getting-started-docs-3.35.92-1.fc32, gnome-initial-setup-3.35.92-1.fc32, gnome-mahjongg-3.35.92-1.fc32, gnome-maps-3.35.92-1.fc32, gnome-multi-writer-3.35.90-1.fc32, gnome-music-3.35.92-1.fc32, gnome-settings-daemon-3.35.92-1.fc32, gnome-shell-3.35.92-1.fc32, gnome-software-3.35.92-1.fc32, gnome-system-monitor-3.35.92-1.fc32, gnome-terminal-3.35.92-1.fc32, gnome-tetravex-3.35.92-1.fc32, gnome-user-docs-3.35.92-1.fc32, gvfs-1.43.92-1.fc32, libgdata-0.17.12-1.fc32, mutter-3.35.92-3.fc32, nautilus-3.35.92-1.fc32, orca-3.35.92-1.fc32, polari-3.35.92-1.fc32, quadrapassel-3.35.92-1.fc32, simple-scan-3.35.92-1.fc32, vala-0.48.0-1.fc32, vte291-0.59.92-2.fc32, wayland-protocols-1.20-1.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2020-03-11 22:46:10 UTC

vte291-0.58.3-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Debarshi Ray 2020-04-03 12:06:32 UTC

I wonder if https://bugzilla.redhat.com/show_bug.cgi?id=1805323 is a duplicate of this one.

Comment 14 Alexander Tsoy 2020-05-23 21:14:49 UTC

(In reply to Egmont Koblinger from comment #0)
> A changelog entry in the patch says:
> 
> > Currently, using C0 controls to emit OSC 777 from PS0 (ie.,
> > PS0=$(printf "\u009D777;preexec\u009C")) causes spurious characters to
> > show up. C1 controls don't seem to suffer from this problem.
> 
> Do you have any more details? What spurious characters appear? In which
> terminal? Has that terminal been notified, is there any public bugreport,
> and has it addressed the problem?
This was caused by some bug in bash-4.4.