Bug 1784345

Summary:	Give a warning when using --tls-destination without --tls
Product:	Red Hat Enterprise Linux Advanced Virtualization	Reporter:	yafu <yafu>
Component:	libvirt	Assignee:	Jiri Denemark <jdenemar>
Status:	CLOSED ERRATA	QA Contact:	yafu <yafu>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.1	CC:	chhu, dzheng, fjin, jdenemar, lmen, rbalakri, xuzhang
Target Milestone:	rc
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-6.0.0-1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-05 09:52:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description yafu 2019-12-17 09:46:52 UTC

Description of problem:
Give a warning when using --tls-destination without --tls


Version-Release number of selected component (if applicable):
libvirt-5.6.0-10.el8.x86_64


How reproducible:
100%


Steps to Reproduce:
1.# virsh migrate rhel8.1 qemu+ssh://dell-per740-03.dell2.lab.eng.bos.redhat.com/system --live --verbose --tls-destination test --p2p --persistent 
Migration: [100 %]
2.
3.

Actual results:
Migration completed successfully without using tls

Expected results:
Give a warning like:
warning: Option --tls is required by option --tls-destination

Additional info:

Comment 2 Jiri Denemark 2019-12-17 13:35:46 UTC

Sent upstream for review: https://www.redhat.com/archives/libvir-list/2019-December/msg01046.html

Comment 4 yafu 2020-01-21 03:10:52 UTC

Verified with libvirt-6.0.0-1.module+el8.2.0+5453+31b2b136.x86_64.

Test steps:
# virsh migrate q35 qemu+ssh://10.66.36.15/system --live --verbose --tls-destination test.com --unsafe
error: Option --tls is required by option --tls-destination

Comment 6 errata-xmlrpc 2020-05-05 09:52:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2017