Bug 1785042

Summary: fedora-review: pass --enable-network when running rpmlint
Product: [Fedora] Fedora Reporter: Jerry James <loganjerry>
Component: fedora-reviewAssignee: Stanislav Ochotnicky <sochotni>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: admiller, carl, leamas.alec, ngompa13, pingou, sochotni
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: fedora-review-0.7.6-1.fc33 fedora-review-0.7.6-1.fc32 fedora-review-0.7.6-1.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-13 03:47:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jerry James 2019-12-18 23:47:29 UTC
Description of problem:
The "Rpmlint (installed packages)" portion of the report always fails on checking URLs.  For example:

rust-noop_proc_macro-devel.noarch: W: invalid-url URL: https://crates.io/crates/noop_proc_macro <urlopen error [Errno -2] Name or service not known>

The problem is that mock disables the network by default.  Please pass --enable-network to mock when running the rpmlint check on the installed packages.

Version-Release number of selected component (if applicable):
fedora-review-0.7.4-1.fc31.noarch

How reproducible:
Always

Steps to Reproduce:
1. Run fedora-review on any open review bug

Actual results:
The URL check on the installed packages always fails.

Expected results:
The URL check should succeed if the URLs are valid.

Additional info:

Comment 1 Ben Cotton 2020-11-03 17:14:43 UTC
This message is a reminder that Fedora 31 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '31'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 31 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 2 Jerry James 2020-11-03 21:42:24 UTC
This has already been fixed in git.  Can we please have a new release of fedora-review to put the fix into the hands of package reviewers?

Comment 3 Fedora Update System 2020-11-11 02:45:52 UTC
FEDORA-2020-20c4ebf164 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-20c4ebf164

Comment 4 Fedora Update System 2020-11-11 02:45:53 UTC
FEDORA-2020-af607360e8 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-af607360e8

Comment 5 Fedora Update System 2020-11-11 02:45:53 UTC
FEDORA-2020-219835ab79 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-219835ab79

Comment 6 Fedora Update System 2020-11-12 04:07:55 UTC
FEDORA-2020-20c4ebf164 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-20c4ebf164`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-20c4ebf164

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-11-12 04:24:29 UTC
FEDORA-2020-219835ab79 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-219835ab79`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-219835ab79

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-11-12 04:42:22 UTC
FEDORA-2020-af607360e8 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-af607360e8`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-af607360e8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-11-13 03:47:05 UTC
FEDORA-2020-219835ab79 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2020-11-20 01:26:07 UTC
FEDORA-2020-af607360e8 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2020-11-20 01:29:07 UTC
FEDORA-2020-20c4ebf164 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.