Bug 1785138

Summary:	subnets and networks leftovers without associated kuryrnet object
Product:	OpenShift Container Platform	Reporter:	Luis Tomas Bolivar <ltomasbo>
Component:	Networking	Assignee:	Luis Tomas Bolivar <ltomasbo>
Networking sub component:	kuryr	QA Contact:	GenadiC <gcheresh>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	gcheresh, itbrown, juriarte
Version:	4.3.0	Keywords:	Triaged
Target Milestone:	---
Target Release:	4.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1785136	Environment:
Last Closed:	2020-01-23 11:19:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1785136
Bug Blocks:

Description Luis Tomas Bolivar 2019-12-19 09:14:51 UTC

+++ This bug was initially created as a clone of Bug #1785136 +++

If the kuryr controller gets restarted, there is still chances of leaking networks and subnet resources. This may happen if it gets restarted after creating the network resources for a namespace and before adding the kuryrnet object (or if that fails and it gets restarted before the rollback). This ends up with networks/subnets that don't have a kuryrnet object associated. In that situation, if the namespace gets deleted, the created network/subnet is left behind, and the clean up mechanism does not account for them either.

Comment 2 Itzik Brown 2020-01-05 08:47:15 UTC

Hi,
Please add information about how to verify

Comment 3 Luis Tomas Bolivar 2020-01-07 07:59:25 UTC

You can run the OCP QE tests, check if there is any network leftover due to failing test or kuryr-kubernetes restarts. And if that so, kill the kuryr-controller and check that the networks get deleted

Comment 4 Jon Uriarte 2020-01-08 17:18:24 UTC

Verified in 4.3.0-0.nightly-2020-01-06-185654 build on top of OSP 13 2019-12-06.2 puddle.

The OCP installer finishes successfully:

 $ oc get clusterversion
 NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
 version   4.3.0-0.nightly-2020-01-06-185654   True        False         175m    Cluster version is 4.3.0-0.nightly-2020-01-06-185654

After running kubernetes/conformance test from origin release-4.3 there are no leftovers, and kuryr-controller pod has been restarted
several times during the tests, which means that it has removed the leftovers upon the restart.

Creating manually a ns, deleting the kuryrnet, the ns and kuryr-controller pod also worked, there were no network or subnet related to it.

$ oc new-project test
$ oc delete ns test; oc delete kuryrnet ns-test; oc -n openshift-kuryr delete pod kuryr-controller-bdd967688-h9nzx
$ openstack network list | grep test; openstack subnet list | grep test
no leftovers related to test namespace

Comment 6 errata-xmlrpc 2020-01-23 11:19:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0062