Bug 1785746

Summary: Stratisd RPM to require libblkid 2.32 or newer
Product: Red Hat Enterprise Linux 8 Reporter: Dennis Keefe <dkeefe>
Component: stratisdAssignee: Dennis Keefe <dkeefe>
Status: CLOSED ERRATA QA Contact: guazhang <guazhang>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.3CC: amulhern, dkeefe, guazhang
Target Milestone: rc   
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 03:55:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dennis Keefe 2019-12-20 20:36:39 UTC
For stratisd identify stratis devices via udev, libblkid 2.32 or newer is required.

https://github.com/stratis-storage/stratisd/issues/1656

Comment 1 Dennis Keefe 2019-12-20 20:37:45 UTC
stratisd spec file will need to be updated to require libblkid 2.32 or newer.

Comment 2 mulhern 2020-01-10 16:44:05 UTC
upstream issue: https://github.com/stratis-storage/stratisd/issues/1656

Comment 3 Dennis Keefe 2020-02-11 22:53:48 UTC
libblkid is part of util-linux.  util-linux is a mandatory package of @core or @minimal, so it would be difficult to 
install stratisd in 8.3 without having libblkid 2.32 or greater.  Are there any other arguments for adding a requirement
for libblkid 2.32 in the specfile for stratisd?

Comment 4 mulhern 2020-02-11 23:54:50 UTC
Are these facts true for any of the other "Requires:" specifications in the spec file?

I would think that this would also be true of systemd-libs, for example, although I would
be less sure of the other three required.

Comment 5 mulhern 2020-02-19 18:07:17 UTC
If we can guarantee that libblkid 2.32 will be in RHEL 8.3, then we need not add the requirement in the spec file. But we might want to strip out other requirements as well, if the same holds for them.

Comment 6 Dennis Keefe 2020-02-20 18:59:02 UTC
Reply to comment 4;  Here are the requires from the specfile

Requires:       xfsprogs
Requires:       device-mapper-persistent-data
Requires:       systemd-libs
Requires:       dbus-libs

For RHEL 8 the comps-baseOS.<architecture>.xml file (located in BaseOS/<architecture>/repodata/ has a group ID for core. Under core
is a list of packages, packages marked with "mandatory" are always installed, packages marked as "default" are installed if not 
specifically excluded, and "optional" must be specifically included.  See: A.2.1. Package selection section in  

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/performing_an_advanced_rhel_installation/kickstart-script-file-format-reference_installing-rhel-as-an-experienced-user 


Groups and packages from comps xml file
core
<packagereq type="mandatory">systemd</packagereq>
<packagereq type="mandatory">xfsprogs</packagereq>
<packagereq type="mandatory">util-linux</packagereq>

base
<packagereq type="mandatory">dbus</packagereq>

Notes from the Red Hat doc link above. There are a few statements about core package group regarding kickstart 
* The Core group is always selected 
* The @Core package group is defined as a minimal set of packages needed for installing a working system
* Disabling the @Core package group with --nocore should be only used for creating lightweight containers; installing a desktop or server system with --nocore will result in an unusable system.

From this information I believe that it wouldn't be reasonable to believe that someone installing stratisd would be doing so on a system that didn't have packages from the core package group.

I believe we can close this ticket because util-linux is part of the core package group.

Information in this bug could be used to create another bug that xfsprogs and systemd-libs (part of systemd) can be
removed from the specfile since they are part of core.  Note the dbus package which holds (dbus-libs) should stay in the
specfile.

Comment 10 guazhang@redhat.com 2020-06-18 03:38:30 UTC
Hello

the RHEL8.3 default include the libblkid-2.32.1-22.el8.x86_64, so move to verified 
[root@storageqe-26 ~]# rpm -qa |grep blk
libblkid-2.32.1-22.el8.x86_64
[root@storageqe-26 ~]# uname -a
Linux storageqe-26.sqe.lab.eng.bos.redhat.com 4.18.0-211.el8.x86_64 #1 SMP Thu Jun 4 08:08:16 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
[root@storageqe-26 ~]#

Comment 13 errata-xmlrpc 2020-11-04 03:55:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (stratis-cli bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4794