Bug 1786376

Summary: [abrt] symlinks: tidy_path(): symlinks killed by SIGSEGV
Product: [Fedora] Fedora Reporter: Tom Bouwman <tombouwman>
Component: symlinksAssignee: Tim Waugh <twaugh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 30CC: redhat, twaugh
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/c2f49c595d66390f4fe3a5088f8b698063ec54e3
Whiteboard: abrt_hash:7f3ef132a068b51884f315a6199ddd4f1fcf3a3b;VARIANT_ID=workstation;
Fixed In Version: symlinks-1.7-1.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-24 17:08:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace
none
File: cgroup
none
File: core_backtrace
none
File: cpuinfo
none
File: dso_list
none
File: environ
none
File: exploitable
none
File: limits
none
File: maps
none
File: mountinfo
none
File: open_fds
none
File: proc_pid_status none

Description Tom Bouwman 2019-12-24 19:34:50 UTC
Description of problem:
I ran "symlinks -r -d /usr" as one of the post steps of the upgrade from Fedora 29 to 30.
This is documented in https://docs.fedoraproject.org/en-US/quick-docs/dnf-system-upgrade/

Version-Release number of selected component:
symlinks-1.4-22.fc30

Additional info:
reporter:       libreport-2.11.3
backtrace_rating: 4
cmdline:        symlinks -r /usr
crash_function: tidy_path
executable:     /usr/bin/symlinks
journald_cursor: s=a77f51d6341647b0a3ed6c79b304e9b7;i=b21a;b=eda9e0044e8b4e1296b4357528ca27fb;m=2a53c0d31;t=59a77c940edfa;x=ee61edd2efa5a416
kernel:         5.2.11-100.fc29.x86_64
rootdir:        /
runlevel:       N 5
type:           CCpp
uid:            0

Truncated backtrace:
Thread no. 1 (3 frames)
 #0 tidy_path at symlinks.c:92
 #1 fix_symlink at symlinks.c:181
 #2 dirwalk at symlinks.c:286

Comment 1 Tom Bouwman 2019-12-24 19:34:53 UTC
Created attachment 1647541 [details]
File: backtrace

Comment 2 Tom Bouwman 2019-12-24 19:34:54 UTC
Created attachment 1647542 [details]
File: cgroup

Comment 3 Tom Bouwman 2019-12-24 19:34:55 UTC
Created attachment 1647543 [details]
File: core_backtrace

Comment 4 Tom Bouwman 2019-12-24 19:34:56 UTC
Created attachment 1647544 [details]
File: cpuinfo

Comment 5 Tom Bouwman 2019-12-24 19:34:57 UTC
Created attachment 1647545 [details]
File: dso_list

Comment 6 Tom Bouwman 2019-12-24 19:34:59 UTC
Created attachment 1647546 [details]
File: environ

Comment 7 Tom Bouwman 2019-12-24 19:35:00 UTC
Created attachment 1647547 [details]
File: exploitable

Comment 8 Tom Bouwman 2019-12-24 19:35:01 UTC
Created attachment 1647548 [details]
File: limits

Comment 9 Tom Bouwman 2019-12-24 19:35:02 UTC
Created attachment 1647549 [details]
File: maps

Comment 10 Tom Bouwman 2019-12-24 19:35:03 UTC
Created attachment 1647550 [details]
File: mountinfo

Comment 11 Tom Bouwman 2019-12-24 19:35:05 UTC
Created attachment 1647551 [details]
File: open_fds

Comment 12 Tom Bouwman 2019-12-24 19:35:06 UTC
Created attachment 1647552 [details]
File: proc_pid_status

Comment 13 Tom Bouwman 2020-01-01 19:03:30 UTC
On my 3rd upgrade from Fedora 29 to 30, this all went OK.

Comment 14 Tim Waugh 2020-01-06 12:29:03 UTC
Test case:

mkdir -p /tmp/x
ln -s ../../../tmp /tmp/x/tmp
symlinks -r /tmp/x

Comment 15 Tom Bouwman 2020-01-06 14:05:08 UTC
I reproduced your simple test case on F30-mate, F30-ws (GNOME) en F31-server.
All are KVM-guests.

Comment 16 Tim Waugh 2020-01-06 14:31:22 UTC
Reported upstream by email.

Comment 17 Tim Waugh 2020-01-08 12:02:32 UTC
New upstream version 1.7 contains the fix. Thanks for reporting this!

Comment 18 redhat 2020-01-12 09:47:07 UTC
Any chance to get a fix for FC31?

Comment 20 Fedora Update System 2020-01-14 01:43:40 UTC
symlinks-1.7-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-623f83ecd2

Comment 21 Fedora Update System 2020-01-24 17:08:25 UTC
symlinks-1.7-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 22 Tom Bouwman 2020-01-24 22:10:51 UTC
Tried:
dnf -y update
dnf list symlinks
Last metadata expiration check: 0:08:11 ago on Fri 24 Jan 2020 10:57:27 PM CET.
Installed Packages
symlinks.x86_64                                                               1.4-23.fc31                                                                @fedora

Stil shows old packages.
Even trying to reinstall from the updates-testing repo, does not update the package.

dnf reinstall symlinks --enablerepo=updates-testing
Last metadata expiration check: 0:00:18 ago on Fri 24 Jan 2020 11:04:17 PM CET.
Dependencies resolved.
================================================================================================================================================================
 Package                               Architecture                        Version                                    Repository                           Size
================================================================================================================================================================
Reinstalling:
 symlinks                              x86_64                              1.4-23.fc31                                fedora                               18 k

Transaction Summary
================================================================================================================================================================

Total download size: 18 k
Installed size: 22 k
Is this ok [y/N]: n