Bug 1786653 (androguard)
| Summary: | Review Request: androguard - Reverse engineering, mal- or goodware analysis of Android applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-05-24 15:33:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1786632, 1786855, 1790100 | ||
| Bug Blocks: | 563471, 1790091 | ||
|
Description
Fabian Affolter
2019-12-26 19:59:23 UTC
- Generate the doc with Sphinx
BuildRequires: python3dist(sphinx)
BuildRequires: python3dist(sphinx-rtd-theme)
BuildRequires: python3dist(sphinxcontrib-programoutput) > 0.8
BuildRequires: python3dist(asn1crypto)
BuildRequires: python3dist(click)
BuildRequires: python3dist(future)
BuildRequires: python3dist(lxml)
BuildRequires: python3dist(ipython)
BuildRequires: python3dist(networkx)
BuildRequires: python3dist(pydot)
BuildRequires: python3dist(python-magic) (To be packaged)
[…]
%install
%py3_install
# generate html docs
PATH=%{buildroot}%{_bindir}:$PATH PYTHONPATH=%{buildroot}%{python3_sitelib} sphinx-build-3 docs html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}
- Include examples in %doc
%doc html examples
- Probably using a doc noarch subpackage
%package docs
Summary: Androguard documentation
%description docs
Documentation for Androguard
[…]
%files docs
%doc html examples
- The python-magic provided by Fedora ("file-magic", https://pypi.org/project/file-magic/) is not the python-magic expected by Androguard: https://pypi.org/project/python-magic/0.4.15/
Please package https://pypi.org/project/python-magic/0.4.15 (pyp2rpm -b3 python-magic) and add it to the BR and RR. Not sure what naming you should use? python-python-magic?
- The tests mostly run without nose-timer: there is one failure regarding magic above and another one. Investigate with upstream.
(In reply to Robert-André Mauchin from comment #1) > - Generate the doc with Sphinx Documentation in sub package > - The python-magic provided by Fedora ("file-magic", > https://pypi.org/project/file-magic/) is not the python-magic expected by > Androguard: https://pypi.org/project/python-magic/0.4.15/ > Please package https://pypi.org/project/python-magic/0.4.15 (pyp2rpm -b3 > python-magic) and add it to the BR and RR. Not sure what naming you should > use? python-python-magic? Should be resolved now. Original package was renamed and the new one is available > - The tests mostly run without nose-timer: there is one failure regarding > magic above and another one. Investigate with upstream. Tests enabled as dependency is present now. %changelog * Wed Apr 01 2020 Fabian Affolter <mail> - 3.3.5-2 - Add docs subpackage (rhbz#1786653) - Enable tests - Fix requirements Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/androguard.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/androguard-3.3.5-2.fc31.src.rpm LGTM, package approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/androguard |