Bug 178668

Summary: Review Request: numpy: A fast multidimensional array facility for Python
Product: [Fedora] Fedora Reporter: Ignacio Vazquez-Abrams <ivazqueznet>
Component: Package ReviewAssignee: Ed Hill <ed>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-extras-list, ndbecker2
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-02-16 16:34:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    
Attachments:
Description Flags
rpmlint output none

Description Ignacio Vazquez-Abrams 2006-01-23 04:15:22 UTC 
Spec Name or Url: http://fedora.ivazquez.net/files/extras/numpy.spec
SRPM Name or Url: http://fedora.ivazquez.net/files/extras/numpy-0.9.4-1.src.rpm
Description: The Numeric Python extensions is a set of extensions to the Python programming language which allows Python programmers to efficiently manipulate large sets of objects organized in grid-like fashion. These sets of objects are called arrays, and they can have any number of dimensions: one dimensional arrays are similar to standard Python sequences, two-dimensional arrays are similar to matrices from linear algebra. Note that one-dimensional arrays are also different from any other Python sequence, and that two-dimensional matrices are also different from the matrices of linear algebra.

This package also contains a version of f2py that works properly with it.
Comment 1 Ed Hill 2006-01-23 05:19:55 UTC 
Hi Ignacio, this is just a very quick look, not a full review:

good:
 + source matches upstream
 + specfile looks sane
 + license looks OK

needswork:
 - the license should probably (?) be in %doc
 - in %build, CFLAGS is set twice (redundant)
 - build on FC-4 fails with this message:

+ /usr/bin/python -c 'import pkg_resources, numpy ; numpy.test(1, 1)'
Traceback (most recent call last):
  File "<string>", line 1, in ?
ImportError: No module named pkg_resources
error: Bad exit status from /var/tmp/rpm-tmp.44127 (%check)
Comment 2 Ignacio Vazquez-Abrams 2006-02-02 19:19:39 UTC 
Updated.
Comment 3 Ed Hill 2006-02-04 03:37:14 UTC 
Created attachment 124151 [details]
rpmlint output
Comment 4 Ed Hill 2006-02-04 04:39:00 UTC 
Hi Ignacio, heres a more thorough review:

good:
 + good parts from comment #1 still good
 + rpmlint produces a bunch of warnings and errors but taking a
     look at them it appears that they're all just brain-dead
     rpmlint annoyances
 + package builds in mock for fc4-i386
 + BR list looks good
 + shared libs looks good (no *.la)
 + dir ownership OK
 + no %files dupes
 + permissions OK
 + has correct clean bits
 + code not content
 + some headers and libs are included but its acceptable
 + ran some simple examples and no segfaults -- good

and I don't see any blockers so its APPROVED.
Comment 5 Ignacio Vazquez-Abrams 2006-02-16 16:34:59 UTC 
Built under FC4 and devel.