Bug 1786875 (python-django-configurations)

Summary:	Review Request: python-django-configurations - A helper for organizing Django settings
Product:	[Fedora] Fedora	Reporter:	Fabian Affolter <mail>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-01 01:30:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1786862, 1786863, 1786869, 1786871
Bug Blocks:	1786920

Description Fabian Affolter 2019-12-28 22:42:10 UTC

Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-django-configurations.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-django-configurations-2.2-1.fc31.src.rpm

Project URL: https://django-configurations.readthedocs.io/

Description:
django-configurations eases Django project configuration by relying on the
composability of Python classes. It extends the notion of Django's module
based settings loading with well established object oriented programming
patterns.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=39965710
rpmlint output:
$ rpmlint python-django-configurations-2.2-1.fc31.src.rpm
python-django-configurations.src: W: spelling-error %description -l en_US composability -> compos ability, compos-ability, comparability
python-django-configurations.src:64: W: macro-in-comment %check
python-django-configurations.src:67: W: macro-in-comment %{buildroot}
python-django-configurations.src:67: W: macro-in-comment %{python3_sitelib}
python-django-configurations.src:67: W: macro-in-comment %{__python3}
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

$ rpmlint python3-django-configurations-2.2-1.fc31.noarch.rpm 
python3-django-configurations.noarch: W: spelling-error %description -l en_US composability -> compos ability, compos-ability, comparability
python3-django-configurations.noarch: W: no-manual-page-for-binary django-cadmin
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-01-07 20:10:50 UTC

Source0:        https://files.pythonhosted.org/packages/source/d/%{pypi_name}/%{pypi_name}-%{version}.tar.gz

→

Source0:        %{pypi_source}

 - Use %{python3_version} or a glob * instead of ?.? because Python 3.10 will break this package otherwise:

%{python3_sitelib}/django_configurations-%{version}-py*.egg-info


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 2 Fabian Affolter 2020-01-07 20:29:49 UTC

Thanks for the review.

Comment 3 Gwyn Ciesla 2020-01-07 22:00:35 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-django-configurations

Comment 4 Fedora Update System 2020-01-24 05:49:29 UTC

python-django-configurations-2.2-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8e9ea20dce

Comment 5 Fedora Update System 2020-01-25 20:19:55 UTC

FEDORA-2020-0dc439250e has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0dc439250e

Comment 6 Fedora Update System 2020-01-26 01:52:18 UTC

python-django-configurations-2.2-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0dc439250e

Comment 7 Fedora Update System 2020-02-01 01:30:25 UTC

python-django-configurations-2.2-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2020-02-03 01:03:18 UTC

python-django-configurations-2.2-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.