Bug 1787119

Summary: --all-logs does not collect all ovirt-hosted-engine-ha logs
Product: Red Hat Enterprise Linux 8 Reporter: Yedidyah Bar David <didi>
Component: sosAssignee: Pavel Moravec <pmoravec>
Status: CLOSED ERRATA QA Contact: Maros Kopec <makopec>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.4CC: agk, bmr, jhunsaker, mhradile, plambri, pmoravec, sbradley
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: sos-3.9.1-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 01:57:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yedidyah Bar David 2019-12-31 09:28:56 UTC 
Description of problem:

It only collects all of /var/log/ovirt-hosted-engine-ha/*.log , but rotated logs of them look (by default) like:

# ls -ltr /var/log/ovirt-hosted-engine-ha/*
-rw-r--r--. 1 vdsm kvm 4498655 Dec 24 11:07 /var/log/ovirt-hosted-engine-ha/broker.log.2019-12-23
-rw-r--r--. 1 vdsm kvm 1870770 Dec 24 11:08 /var/log/ovirt-hosted-engine-ha/agent.log.2019-12-23
-rw-r--r--. 1 vdsm kvm 4499980 Dec 25 11:07 /var/log/ovirt-hosted-engine-ha/broker.log.2019-12-24
-rw-r--r--. 1 vdsm kvm 1870384 Dec 25 11:08 /var/log/ovirt-hosted-engine-ha/agent.log.2019-12-24
-rw-r--r--. 1 vdsm kvm 5179218 Dec 26 12:56 /var/log/ovirt-hosted-engine-ha/broker.log.2019-12-25
-rw-r--r--. 1 vdsm kvm 2238442 Dec 26 12:57 /var/log/ovirt-hosted-engine-ha/agent.log.2019-12-25
-rw-r--r--. 1 vdsm kvm 4527209 Dec 27 12:56 /var/log/ovirt-hosted-engine-ha/broker.log.2019-12-26
-rw-r--r--. 1 vdsm kvm 1871863 Dec 27 12:57 /var/log/ovirt-hosted-engine-ha/agent.log.2019-12-26
-rw-r--r--. 1 vdsm kvm 4527600 Dec 28 12:56 /var/log/ovirt-hosted-engine-ha/broker.log.2019-12-27
-rw-r--r--. 1 vdsm kvm 1871344 Dec 28 12:57 /var/log/ovirt-hosted-engine-ha/agent.log.2019-12-27
-rw-r--r--. 1 vdsm kvm 4527472 Dec 29 12:56 /var/log/ovirt-hosted-engine-ha/broker.log.2019-12-28
-rw-r--r--. 1 vdsm kvm 1871802 Dec 29 12:57 /var/log/ovirt-hosted-engine-ha/agent.log.2019-12-28
-rw-r--r--. 1 vdsm kvm 4526553 Dec 30 12:56 /var/log/ovirt-hosted-engine-ha/broker.log.2019-12-29
-rw-r--r--. 1 vdsm kvm 1871517 Dec 30 12:57 /var/log/ovirt-hosted-engine-ha/agent.log.2019-12-29
-rw-r--r--. 1 vdsm kvm 4236263 Dec 31 11:24 /var/log/ovirt-hosted-engine-ha/broker.log
-rw-r--r--. 1 vdsm kvm 1750131 Dec 31 11:24 /var/log/ovirt-hosted-engine-ha/agent.log

Version-Release number of selected component (if applicable):
All

How reproducible:
Always

Steps to Reproduce:
1. Run sosreport with --all-logs
2.
3.

Actual results:
Collects only agent.log and broker.log

Expected results:
Collects all rotated logs, agent.log* and broker.log*

Additional info:
I wonder if we should always collect all HA logs, regardless of '--all-logs', similarly to what vdsm does. It's quite annoying to get a sosreport with enough vdsm logs for a particular case but not enough HA logs...
Comment 1 Jake Hunsaker 2019-12-31 20:04:19 UTC 
The rotated logs seem small enough to collect by default in my opinion. We could collect them all up to `--log-size` (25MB by default), leaving `--all-logs` to gather them without size restriction.

Proposal: https://github.com/sosreport/sos/pull/1906
Comment 2 Pavel Moravec 2020-01-01 08:18:51 UTC 
Thaks for BZ and PR, scheduling to 8.3 so far.
Comment 10 errata-xmlrpc 2020-11-04 01:57:52 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (sos bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4534